Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance kfp client keywords and add basic DSP acceptance test suite #1828

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Enhance kfp client keywords and add basic DSP acceptance test suite #1828

merged 6 commits into from
Sep 19, 2024

Conversation

jgarciao
Copy link
Contributor

  • Adds more keywords to interact with the DSP API server using the KFP client library
  • Adds a new basic acceptance test suite using the above keywords
  • Sorts existing test suites

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
540 0 0 540 100

@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Sep 19, 2024
@jgarciao jgarciao changed the title Enhance kfp client keywords and basic DSP acceptance test suite Enhance kfp client keywords and add basic DSP acceptance test suite Sep 19, 2024
@jgarciao
Reformat files with ruff to fix linter errors
9969c8f 
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@jgarciao
Fix some robocop warnings
375d96e 
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao
Copy link
Contributor Author

jgarciao commented Sep 19, 2024 •
edited
Loading

Tested in rhoai-test-flow/393. All pipeline tests passed except the ray test, but I think it's not related to these changes. I'll merge it now and send a follow-up PR if needed

@jgarciao jgarciao added the verified This PR has been tested with Jenkins label Sep 19, 2024
@jgarciao jgarciao merged commit c2822a7 into red-hat-data-services:master Sep 19, 2024
10 checks passed
@jgarciao jgarciao added new test New test(s) added (PR will be listed in release-notes) and removed enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeAlonso FedeAlonso FedeAlonso approved these changes

@diegolovison diegolovison diegolovison approved these changes

Assignees
No one assigned
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgarciao @diegolovison @FedeAlonso