RHOAIENG-12833 - Validate Image Pull Path Is From registry.redhat.io #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmahoneyrh
added
needs testing
Robot Results
|
mattmahoneyrh
requested review from
CFSNM,
asanzgom,
MarianMacik and
jstourac
mattmahoneyrh
added
verified
CFSNM
approved these changes
Sep 13, 2024
asanzgom
reviewed
Sep 16, 2024
There was a problem hiding this comment.
@mattmahoneyrh correct me if I'm wrong but I think this Test Case should also be running for ODH deployments to check depending on the product, the correct deployment image. Isn't it?
|
|
@asanzgom Yes, the check will run for both ODH and RHOAI (CPaaS builds). |
asanzgom
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this enhancement is to check that the Component Deployment image pull path is from registry.redhat.io, when expected to be so.
Note: kserve-controller-manager is an exception which is pulled from quay.io, thus not validated for pull path registry.redhat.io