Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework in some of the operator test cases #1761

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

CFSNM
Copy link
Contributor

@CFSNM CFSNM commented Aug 30, 2024

No description provided.

@CFSNM CFSNM self-assigned this Aug 30, 2024
${DSCI_RELEASE_VERSION}= Get Resource Attribute ${OPERATOR_NAMESPACE}
... DSCInitialization ${DSCI_NAME} ${RELEASE_VERSION_ATTRIBUTE_PATH}

Set Suite Variable ${DSC_RELEASE_NAME}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
... DSCInitialization ${DSCI_NAME} ${RELEASE_VERSION_ATTRIBUTE_PATH}

Set Suite Variable ${DSC_RELEASE_NAME}
Set Suite Variable ${DSCI_RELEASE_NAME}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR

Set Suite Variable ${DSC_RELEASE_NAME}
Set Suite Variable ${DSCI_RELEASE_NAME}
Set Suite Variable ${DSC_RELEASE_VERSION}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
Set Suite Variable ${DSC_RELEASE_NAME}
Set Suite Variable ${DSCI_RELEASE_NAME}
Set Suite Variable ${DSC_RELEASE_VERSION}
Set Suite Variable ${DSCI_RELEASE_VERSION}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
${expected_release_name}= Set Variable ${ODH_RELEASE_NAME}
END

Set Suite Variable ${expected_release_name}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
${expected_release_name}= Set Variable ${ODH_RELEASE_NAME}
END

Set Suite Variable ${expected_release_name}

Check warning

Code scanning / Robocop

Test, suite and global variables should be uppercase Warning test

Test, suite and global variables should be uppercase
Suite Teardown RHOSi Teardown


*** Test Cases ***
Verify That DSC And DSCI Release.Name Attribute matches required value
Verify That DSC And DSCI Release.Name Attribute matches ${expected_release_name}

Check warning

Code scanning / Robocop

Not allowed character '{{ character }}' found in {{ block_name }} name Warning test

Not allowed character '.' found in 'Verify That DSC And DSCI Release.Name Attribute matches ${expected_release_name}' test case name
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
530 0 0 530 100

@CFSNM CFSNM force-pushed the rework_operator_tests branch from 049d8ac to 31443e5 Compare September 2, 2024 09:18
Copy link

sonarqubecloud bot commented Sep 2, 2024

@CFSNM CFSNM merged commit 7f75863 into red-hat-data-services:master Sep 2, 2024
10 checks passed
@CFSNM CFSNM deleted the rework_operator_tests branch September 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants