Fix keyword to watch SM cluster provisioning logs and increase timeout #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdattoma
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| END | ||
| Run Keyword And Continue On Failure Should Be Equal As Integers ${return_code} ${0} | ||
| ${hive_pods_status} = Run And Return Rc oc get pod -n ${namespace} --no-headers | awk '{print $3}' | grep -v 'Completed' | ||
| IF ${hive_pods_status} != 0 |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note
Robot Results
|
kobihk
reviewed
Aug 29, 2024
kobihk
previously approved these changes
Aug 29, 2024
manosnoam
requested changes
Aug 29, 2024
manosnoam
reviewed
Aug 29, 2024
bdattoma
added
verified
bdattoma
force-pushed
the
fix_hive_watch
branch
from
3b2a3a9 to
f307344
Compare
|
manosnoam
approved these changes
Aug 29, 2024
kobihk
approved these changes
Aug 29, 2024
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Sep 1, 2024
red-hat-data-services#1754) * draft fix hive watcher * do not print dots when process is not producing new outputs * wait for ns to be created before looking for logs * wait until logs are available to be fetched * fix wait for pod * fix wait kw call * clean new code * increase provisioning timeout * extend label selector for cd deployments * use job type label for cluster pool deployments * fix catenation separator * remove commented line * fix robocop alerts * minor change * increase timeout further * apply suggestions from reviews * remove wrong return variables * fix robocop alert * remove debug lines
|
Hi @bdattoma although you added Please also add |
tonyxrmdavidson
pushed a commit
to tonyxrmdavidson/ods-ci
that referenced
this pull request
Sep 4, 2024
red-hat-data-services#1754) * draft fix hive watcher * do not print dots when process is not producing new outputs * wait for ns to be created before looking for logs * wait until logs are available to be fetched * fix wait for pod * fix wait kw call * clean new code * increase provisioning timeout * extend label selector for cd deployments * use job type label for cluster pool deployments * fix catenation separator * remove commented line * fix robocop alerts * minor change * increase timeout further * apply suggestions from reviews * remove wrong return variables * fix robocop alert * remove debug lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content of the PR:
Watch Hive Install Logkeyword to avoid RHOAIENG-10829 bugThis won't necessarily fix some of the failures we have seen in CI while provisioning clusters, but would:
PR validation:
PSI provisioning OK
IBM Cloud provisioning OK
