Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IDE test suite directory with proper nested suites #1562

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

bdattoma
Copy link
Contributor

@bdattoma bdattoma commented Jun 26, 2024

  1. create a new directory for IDE test suites
  2. move the old JH test suites under IDE directory
  3. move the test suites of ISVs related to IDEs (i.e., Anaconda, Openvino, Aikit, Watson Studio)
  4. patch the Import and Library statement accordingly

PR validation:

  • dryrun is clean - PASS
  • smoke regression: rhods-ci-pr-test/3025 PASS
  • sanity regression: rhods-ci-pr-test/3032 17/27 failures not related to this PR - seem to be some env issue
  • AiKit Tier2: rhods-ci-pr-test/3029 FAILED because the test is broken/outdated and not for this PR

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
495 0 0 495 100

@bdattoma bdattoma self-assigned this Jun 26, 2024
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins misc Miscelaneus (PR will be listed in release-notes) verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jun 26, 2024
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the test suites of ISVs related to IDEs (i.e., Anaconda, Openvino, Aikit, Watson Studio)

@harshad16, @atheo89 are we responsible for these, as IDE team? I never really touched them. If it's not our purview, then they should be placed somewhere else.

The docs are https://www.redhat.com/en/resources/openshift-data-science-overview#section-4 and https://catalog.redhat.com/solutions/detail/5d6a4953195a4114a6136fb63206d540 and the Resources tab https://docs.redhat.com/en/documentation/red_hat_openshift_ai_self-managed/2.8/html/getting_started_with_red_hat_openshift_ai_self-managed/tutorials-for-data-scientists_get-started

@jiridanek jiridanek requested review from harshad16 and atheo89 June 26, 2024 15:31
@harshad16
Copy link
Member

There is no clear direction of ISV , it is hard to comment on this.

@bdattoma
Copy link
Contributor Author

move the test suites of ISVs related to IDEs (i.e., Anaconda, Openvino, Aikit, Watson Studio)

@harshad16, @atheo89 are we responsible for these, as IDE team? I never really touched them. If it's not our purview, then they should be placed somewhere else.

The docs are https://www.redhat.com/en/resources/openshift-data-science-overview#section-4 and https://catalog.redhat.com/solutions/detail/5d6a4953195a4114a6136fb63206d540 and the Resources tab https://docs.redhat.com/en/documentation/red_hat_openshift_ai_self-managed/2.8/html/getting_started_with_red_hat_openshift_ai_self-managed/tutorials-for-data-scientists_get-started

The concept is that these ISVs I moved under IDE folder are themselves IDEs or Jupyter images, hence they would logically fall under IDE scope in my opinion

@bdattoma bdattoma requested a review from jiridanek June 27, 2024 09:04
@bdattoma bdattoma merged commit 2a98d1a into red-hat-data-services:master Jun 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Miscelaneus (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants