Move Serving and Pipelines suites out of Dashboard folder #1553
Conversation
bdattoma
added
needs testing
bdattoma
requested review from
jgarciao,
diegolovison,
manosnoam,
FedeAlonso,
mwaykole,
lugi0 and
tarukumar
Robot Results
|
|
Besides running Smoke to see nothing is broken, lgtm. |
yes, didn't get time to do it yet. Will do asap. Ty |
|
PR validation:
|
bdattoma
added
verified
are you sure? |
| *** Settings *** | ||
| Documentation Collection of UI tests to validate the model serving stack for Large Language Models (LLM) |
There was a problem hiding this comment.
This test suite is all about UI tests, wouldn't it make more sense to have it in the 400__ods_dashboard folder?
I remember the beginning of a discussion about this topic but I don't know if we came to a decision in the end
There was a problem hiding this comment.
I feel the same about 434__data-science-pipelines-ui.robot. Now it is a Dashboard UI test and it's maintained by the Dashboard team. In case it was run by the "Gated Auto-Merger tool" it should be linked to Dashboard source synchronization, not to data-science-pipelines-operator
Related to this, maybe 434__data-science-pipelines-ui.robot should have tag Dashboard-DataSciencePipelines (or DataSciencePipelines-UI) instead of DataSciencePipelines. What do you think @FedeAlonso ?
There was a problem hiding this comment.
Yes, I explained the change of the decision in the thread and in the document of the proposal. It's to avoid having tests sparse: test suite for model mesh is mainly UI based with some mix of CLI. If we move that suire to Dashboard UI we would be losing the model mesh coverage under Serving directory - test coverage of serving would be sparse over 2 folders.
So, to do things consistently over all the components - at least trying - I decided to revert the decision and gather in the same repository the CLI and UI tests of the same component.
first PR part of the test suites refactoring