Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pipeline setting pip_index_url and pip_trusted_host #1549

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented Jun 20, 2024

  • Simplifies the code adding the env vars PIP_INDEX_URL and PIP_TRUSTED_HOST
  • Adds a new sample flip_coin_pip_index_url.py
  • Tested manually on a disconnected cluster

@jgarciao jgarciao added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Jun 20, 2024
@jgarciao jgarciao requested review from apodhrad and FedeAlonso June 20, 2024 11:00
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
482 0 0 482 100

@jgarciao jgarciao requested a review from CFSNM June 20, 2024 13:11
Copy link
Contributor

@CFSNM CFSNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgarciao jgarciao merged commit 0795645 into red-hat-data-services:master Jun 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants