Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for vllm model deployment from UI #1531

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Add Support for vllm model deployment from UI #1531

merged 3 commits into from
Jun 14, 2024

Conversation

tarukumar
Copy link
Contributor

No description provided.

${test_namespace}= Set Variable ${TEST_NS}
${isvc__name}= Set Variable e5-mistral-7b-gpu
${model_name}= Set Variable e5-mistral-7b
${requests}= Create Dictionary nvidia.com/gpu=1

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
${isvc__name}= Set Variable e5-mistral-7b-gpu
${model_name}= Set Variable e5-mistral-7b
${requests}= Create Dictionary nvidia.com/gpu=1
${limits}= Create Dictionary nvidia.com/gpu=1

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
[Tags] Sanity Tier1 RHOAIENG-6344 Resources-GPU
${test_namespace}= Set Variable ${TEST_NS}
${isvc__name}= Set Variable gpt2-gpu
${model_name}= Set Variable gpt2

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${model_name}' is assigned but not used
Container Hardware Resources Should Match Expected container_name=kserve-container
... pod_label_selector=serving.kserve.io/inferenceservice=${isvc__name}
... namespace=${test_namespace} exp_requests=${requests} exp_limits=${limits}
Query Model Multiple Times model_name=${isvc__name} isvc_name=${isvc__name} runtime=${VLLM_RUNTIME_NAME} protocol=http

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (133/120)
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
477 0 0 477 100

@tarukumar tarukumar added new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins labels Jun 14, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar merged commit f4e8451 into red-hat-data-services:master Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants