-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for vllm model deployment from UI #1531
Conversation
Signed-off-by: Tarun Kumar <[email protected]>
...ts/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_other_runtimes_UI.robot
Fixed
Show fixed
Hide fixed
${test_namespace}= Set Variable ${TEST_NS} | ||
${isvc__name}= Set Variable e5-mistral-7b-gpu | ||
${model_name}= Set Variable e5-mistral-7b | ||
${requests}= Create Dictionary nvidia.com/gpu=1 |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
${isvc__name}= Set Variable e5-mistral-7b-gpu | ||
${model_name}= Set Variable e5-mistral-7b | ||
${requests}= Create Dictionary nvidia.com/gpu=1 | ||
${limits}= Create Dictionary nvidia.com/gpu=1 |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
[Tags] Sanity Tier1 RHOAIENG-6344 Resources-GPU | ||
${test_namespace}= Set Variable ${TEST_NS} | ||
${isvc__name}= Set Variable gpt2-gpu | ||
${model_name}= Set Variable gpt2 |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
...ts/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_other_runtimes_UI.robot
Fixed
Show fixed
Hide fixed
...ts/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_other_runtimes_UI.robot
Fixed
Show fixed
Hide fixed
Container Hardware Resources Should Match Expected container_name=kserve-container | ||
... pod_label_selector=serving.kserve.io/inferenceservice=${isvc__name} | ||
... namespace=${test_namespace} exp_requests=${requests} exp_limits=${limits} | ||
Query Model Multiple Times model_name=${isvc__name} isvc_name=${isvc__name} runtime=${VLLM_RUNTIME_NAME} protocol=http |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
Signed-off-by: Tarun Kumar <[email protected]>
...ts/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_other_runtimes_UI.robot
Fixed
Show fixed
Hide fixed
Signed-off-by: Tarun Kumar <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.