[fix] stabilize the ODS-1864 test by scrolling button into view #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
added
verified
Robot Results
|
This stabilizes the `Verify User Can Create A Workbench With Environment Variables` test - it usually pass just fine locally, but fails on Jenkins since the button isn't clickable as it's not in the view of the browser. This tries to move the button into the center of the view. Also, unnecessary version check removed.
jstourac
force-pushed
the
stabilizeOds1864
branch
from
a562acf to
dc1c52b
Compare
|
jiridanek
reviewed
Jun 13, 2024
| ... //section[@aria-label="Environment variables"]/div[contains(@class, "-l-split")][${idx}]//button[@data-testid="another-key-value-pair-button"] # robocop: disable:line-too-long | ||
| # Assure that the button we want to click is in the view | ||
| Execute Javascript | ||
| ... document.evaluate('${another_key_button_xpath}', document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.scrollIntoView() # robocop: disable:line-too-long |
There was a problem hiding this comment.
There was a problem hiding this comment.
hm, that is good, no? 🙂
jiridanek
approved these changes
Jun 13, 2024
FedeAlonso
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stabilizes the
Verify User Can Create A Workbench With Environment Variablestest - it usually pass just fine locally, but fails onJenkins since the button isn't clickable as it's not in the view of the
browser.
This tries to move the button into the center of the view.
Also, unnecessary version check removed.
CI:
/job/rhods/job/rhods-sanity/1682