Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Data Science Pipelines to slim down sanity (Sanity on a diet) #1481

Merged
merged 10 commits into from
May 29, 2024

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented May 27, 2024

  • Moves some tests from Sanity to Tier1
  • Splits some tests in 2
  • Fixes HabanaAI test
  • Fixes xpath changes in RHOAI 2.10

Tested sucessfully at rhods-ci-pr-test/2828/ (1 failed test unrelated to the changes)

@jgarciao jgarciao changed the title Sanity diet pipelines Refactor Data Science Pipelines to slim down sanity (Sanity on a diet) May 27, 2024
Copy link
Contributor

github-actions bot commented May 27, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
466 0 0 466 100

jgarciao added 4 commits May 27, 2024 15:05
Adds scripts and dependencies to integrate with Sealights.

Note: currently, this integration scripts only work with the requests
library==2.6.0. As rpaframework needs 2.8.2 or newer, I had to temporally
remove the dependency to this framework and comment out the keyword using it
(Protect Sensitive Variables In Keywords)

Signed-off-by: Jorge Garcia Oncins <[email protected]>
…amework dep"

This reverts commit b15eb4ec2a7ebf0a44e80e79b5f2d60021cdf699.
@jgarciao jgarciao force-pushed the sanity-diet-pipelines branch from 5fff53e to a0d0ae8 Compare May 27, 2024 13:06
jgarciao added 2 commits May 28, 2024 09:46
@jgarciao jgarciao requested review from diegolovison and jstourac May 28, 2024 15:40
@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label May 28, 2024
@jgarciao jgarciao requested a review from FedeAlonso May 28, 2024 15:43
FedeAlonso
FedeAlonso previously approved these changes May 28, 2024
Copy link
Contributor

@FedeAlonso FedeAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

diegolovison
diegolovison previously approved these changes May 28, 2024
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@jgarciao jgarciao dismissed stale reviews from diegolovison and FedeAlonso via 4b140ec May 28, 2024 20:46
FedeAlonso
FedeAlonso previously approved these changes May 29, 2024
This was needed in order to have pipeline Smoke tests near the 5m goal

Signed-off-by: Jorge Garcia Oncins <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao jgarciao added the verified This PR has been tested with Jenkins label May 29, 2024
@jgarciao jgarciao merged commit 37ba874 into red-hat-data-services:master May 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants