Add ibmcloud among supported platform for RHOAI install task #1364
Conversation
bdattoma
added
verified
bdattoma
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
bdattoma
added
verified
|
|
ods_ci/tasks/Tasks/rhods_olm.robot
Outdated
| @@ -11,7 +11,7 @@ Library String | |||
| ${cluster_type} selfmanaged | |||
| ${image_url} ${EMPTY} | |||
| ${RHODS_OSD_INSTALL_REPO} None | |||
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA | |||
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA IBM_Cloud | |||
There was a problem hiding this comment.
It's a nitpick, but could be possible to:
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA IBM_Cloud | |
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA IBM_Cloud |
ods_ci/tasks/Tasks/rhods_olm.robot
Outdated
| @@ -11,7 +11,7 @@ Library String | |||
| ${cluster_type} selfmanaged | |||
| ${image_url} ${EMPTY} | |||
| ${RHODS_OSD_INSTALL_REPO} None | |||
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA | |||
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA IBM_Cloud | |||
There was a problem hiding this comment.
Hm, one more thing - I noticed now that we use uppercase for all the other variants. Wouldn't it be better to use IBM_CLOUD instead of IBM_Cloud? (same would have to apply also for the Jenkins code later on).
There was a problem hiding this comment.
I used Camel Case cos the others are all abbreviation.
I don't think it's a big deal, I can make it upper case but don't see much value in one of the other option
There was a problem hiding this comment.
Upper case - easier to remember (don't have to think what part is uppercase and what part not); I don't insist. If nobody else has objections.
There was a problem hiding this comment.
Maybe we can use only IBM - 3 characters as most of the other platforms
There was a problem hiding this comment.
I'll make it upper case, cheap change.
Kobi I wanted to keep the original Cloud name like we do for the other providers
There was a problem hiding this comment.
Don't know why, but i get FORTRAN vibes from this uppercase thing https://www.fortran90.org/src/best-practices.html
| @@ -11,7 +11,7 @@ | |||
| ${cluster_type} selfmanaged | |||
| ${image_url} ${EMPTY} | |||
| ${RHODS_OSD_INSTALL_REPO} None | |||
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA | |||
| @{SUPPORTED_TEST_ENV} AWS AWS_DIS GCP PSI PSI_DIS ROSA IBM_CLOUD | |||
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note
|
No description provided.