Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace black and isort with ruff #1337

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Mar 28, 2024

It's very fast, even without filtering for changed files the way isort/black did

image

@jiridanek jiridanek force-pushed the jd_ruff_uber_alles branch from 09fc62f to 36ce8c0 Compare March 28, 2024 19:40
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
450 0 0 450 100

@jiridanek jiridanek force-pushed the jd_ruff_uber_alles branch from 36ce8c0 to 3268cd5 Compare March 28, 2024 20:04
@jstourac
Copy link
Member

Thank you for this. One comment, otherwise LGTM.

So to be sure, because I know nothing 🙂 - this replaces all the checks we had with black and isort? Or is it just some subset now?

@jiridanek
Copy link
Member Author

So to be sure, because I know nothing 🙂 - this replaces all the checks we had with black and isort? Or is it just some subset now?

It's the same

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

@jiridanek jiridanek requested a review from jstourac March 28, 2024 20:52
@jstourac jstourac added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Mar 29, 2024
@jiridanek jiridanek requested review from manosnoam and bdattoma March 29, 2024 08:33
@jiridanek jiridanek merged commit bc04b46 into red-hat-data-services:master Mar 29, 2024
10 checks passed
@jiridanek jiridanek deleted the jd_ruff_uber_alles branch March 29, 2024 12:23
@jiridanek jiridanek added utils Enhancements in scripts and CI/CD (PR will be listed in release-notes) and removed enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Mar 29, 2024
@jiridanek jiridanek mentioned this pull request Apr 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
utils Enhancements in scripts and CI/CD (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants