-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DependencyLibrary to support test case/suite dependency #1323
Add DependencyLibrary to support test case/suite dependency #1323
Conversation
Robot Framework DependencyLibrary allows creating dependency between test cases and test suites. For example, if test A must be executed before test B (because B expect some resources created by A), but test A failed - then test B will not be executed. Using DependencyLibrary often in our sequential tests can save run and diagnostic time due to failed tests that were dependent on others. This commit includes a first use of `Depends On Test` KW in: 420__model_serving.robot suite. Signed-off-by: manosnoam <[email protected]>
Robot Results
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not in favor of having the dependent tests in general (setup and teardown seem nicer to me), but I agree that with our current situation and that setup may be slow for our use case, this can help. Thank you.
Also, there are some major upgrades of python dependencies included with this, so hopefully all will work as expected. Would be nice to run a couple of more tests (smoke?) with this PR too, though.
Agree with Jan on running the smoke to make sure nothing is broken |
Counting on test setup (which means call test teardown later too) brings more code + more test runtime + more maintenance + debug time on falied tests that counts on earlier tests, as in my example: Once we start to adopt it in our code, which anyhow uses a lot of dependency - without specifying it in the tests sometimes - we would save much more setup code lines, and failure analysis time.
Yes, running as we speak :) |
a3de25b
into
red-hat-data-services:master
I verified on 2.9 and the the pass rate was similar as we had for 2.9 before this commit. |
Robot Framework
DependencyLibrary
allows creating dependency between test cases and test suites.For example, we can create the foloowing logic:
If test A must be executed before test B, because test B expects some resources created by test A,
but test A failed - then test B will not be executed and marked as skipped.
Adopting
DependencyLibrary
Keywards often in our sequential tests can save a lot of run-time and diagnostic time, in case of failed tests that were dependent on previous tests.This commit includes a first use of the KW
Depends On Test
in: 420__model_serving.robot suite.