Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to open also ODH via application list #1319

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add support to open also ODH via application list #1319

merged 2 commits into from
Mar 28, 2024

Conversation

jstourac
Copy link
Member

  • some small refactoring in a separate commit (will squash after approved)

CI: tested locally

RHOAI:

./ods_ci/run_robot_test.sh --test-case ods_ci/tests/Tests/500__jupyterhub/test.robot --open-report true

Screenshot from 2024-03-25 18-38-09

ODH (we don't have a fully functional build so the tests cannot pass completely) but passed the point of changes in this PR just fine:

./ods_ci/run_robot_test.sh --test-case ods_ci/tests/Tests/500__jupyterhub/test.robot --extra-robot-args '--variablefile ./ods_ci/test-variables-odh-overwrite.yml' --open-report true

jstourac added 2 commits March 25, 2024 18:28
@jstourac
[Fix] use a constant for ODH page title
91d042b 
This constant is used elsewhere already and is being overriden to a
proper value when running with ODH by using the
`./ods_ci/test-variables-odh-overwrite.yml` file.
@jstourac
Tiny refactor and formatting update
9fecd28
@jstourac jstourac self-assigned this Mar 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jstourac jstourac requested review from tarukumar and lugi0 March 25, 2024 17:40
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
448 0 0 448 100

@jstourac jstourac added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Mar 26, 2024
@MatejHorinek MatejHorinek self-requested a review March 28, 2024 08:37
@jstourac
Copy link
Member Author

Thank you guys, merging!

@jstourac jstourac merged commit 4676158 into red-hat-data-services:master Mar 28, 2024
12 checks passed
@jstourac jstourac deleted the fixOdhJupyter branch March 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jiridanek jiridanek jiridanek approved these changes

@tarukumar tarukumar Awaiting requested review from tarukumar

@lugi0 lugi0 Awaiting requested review from lugi0

@MatejHorinek MatejHorinek Awaiting requested review from MatejHorinek

Assignees

@jstourac jstourac

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstourac @jiridanek @bdattoma