Fix deletion confirmation message change in RHOAI 2.9.0 Dashboard

[jiridanek]

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
448	0	0	448	100

[jstourac]

This is supposed to be against 2.9 release. Please don't merge until we decide whether we'll branch 2.8 already.

[jiridanek]

@jstourac I set Milestone to 2.9.0. Is it still appropriate to have the PR as draft, when the changes in it are actually complete? I understand it is a practical safety measure, but still it feels wrong to me.

Maybe we should have a version.txt in the repository and a PR check that compares with that. So these ahead-of-time PRs would have failed CI, to indicate they should not be merged. Meanwhile, I guess I can accept the Draft.

[jstourac]

Okay, obviously different understanding. Personally I don't mind having PRs as drafts even if they are complete since it's safer than the do-not-merge label. But feel free to override me, I believe I may be just sole in this opinion.