Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codellama-34b-instruct-hf test #1263

Merged
merged 9 commits into from
Mar 8, 2024

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Mar 7, 2024

No description provided.

@lugi0 lugi0 added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Mar 7, 2024
@lugi0 lugi0 requested review from mwaykole, bdattoma and tarukumar March 7, 2024 10:31
@lugi0 lugi0 self-assigned this Mar 7, 2024
@@ -227,6 +227,41 @@
... AND
... Run Keyword If "${KSERVE_MODE}"=="RawDeployment" Terminate Process llm-query-process kill=true

Verify User Can Serve And Query A codellama/codellama-34b-instruct-hf Model

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test

Test case 'Verify User Can Serve And Query A codellama/codellama-34b-instruct-hf Model' is too long (36/20)
... namespace=${test_namespace}
Wait For Pods To Be Ready label_selector=serving.kserve.io/inferenceservice=${model_name}
... namespace=${test_namespace} timeout=900s
Run Keyword If "${KSERVE_MODE}"=="RawDeployment"

Check warning

Code scanning / Robocop

'{{ statement_name }}' is deprecated since Robot Framework version {{ version }}, use '{{ alternative }}' instead Warning test

'Run Keyword If' is deprecated since Robot Framework version 5.*, use 'IF' instead
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
445 0 0 445 100

Set Project And Runtime runtime=${TGIS_RUNTIME_NAME} namespace=${test_namespace}
... download_in_pvc=${DOWNLOAD_IN_PVC} model_name=${model_name}
... storage_size=80Gi model_path=${model_path}
${requests}= Create Dictionary memory=130Gi

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
@lugi0 lugi0 added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Mar 7, 2024
@lugi0
Copy link
Contributor Author

lugi0 commented Mar 7, 2024

tested in rhods-ci-pr-test/2582

bdattoma
bdattoma previously approved these changes Mar 7, 2024
Signed-off-by: Luca Giorgi <[email protected]>
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lugi0
Copy link
Contributor Author

lugi0 commented Mar 7, 2024

final validation done in rhods-ci-pr-test/2583

@tarukumar tarukumar merged commit a78010a into red-hat-data-services:master Mar 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants