add existing e2e test as a sanity test for codeflare #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
sutaakar
reviewed
Mar 7, 2024
ods_ci/tests/Tests/650__distributed_workloads/test-run-codeflare-tests.robot
Outdated
Show resolved
Hide resolved
abhijeet-dhumal
force-pushed
the
add_sanity_test_for_codeflare
branch
from
8a546c2 to
6250095
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ods_ci/tests/Tests/650__distributed_workloads/test-run-codeflare-tests.robot
Fixed
Show fixed
Hide fixed
abhijeet-dhumal
force-pushed
the
add_sanity_test_for_codeflare
branch
from
6250095 to
928d62b
Compare
|
sutaakar
approved these changes
Mar 8, 2024
jiripetrlik
requested changes
Mar 8, 2024
| @@ -19,6 +19,7 @@ ${NOTEBOOK_IMAGE_STREAM_NAME} %{NOTEBOOK_IMAGE_STREAM_NAME=s2i-generic-data-sc | |||
| Run TestMNISTPyTorchMCAD E2E test | |||
| [Documentation] Run Go E2E test: TestMNISTPyTorchMCAD | |||
| [Tags] ODS-2543 | |||
| ... Sanity | |||
| ... Tier2 | |||
There was a problem hiding this comment.
Please remove "Tier2" tag as it will be run as part of "Sanity" tests. It doesn't make sense to run the same test twice.
There was a problem hiding this comment.
I would rather prefer to keep it, so if you check Tier2 results you can see all the relevant tests.
There was a problem hiding this comment.
Understand, I have no strong opinion on this.
jiripetrlik
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHOAIENG-3815