Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New xpath on model serving runtime selection dropdown #1257

Merged
merged 3 commits into from
Mar 7, 2024
Merged

fix: New xpath on model serving runtime selection dropdown #1257

merged 3 commits into from
Mar 7, 2024

Conversation

FedeAlonso
Copy link
Contributor

The xpath for the Model Serving selection dropdown has changed in the 2.8

Fix for tests:

  • ODS-2276: Verify RHODS Admins Can Import A Custom Serving Runtime Template By Uploading A YAML file
  • ODS-2279: Verify RHODS Admins Can Delete A Custom Serving Runtime Template

image

@FedeAlonso FedeAlonso added the verified This PR has been tested with Jenkins label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
442 0 0 442 100

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdattoma
Copy link
Contributor

bdattoma commented Mar 7, 2024

doesn't the UI requires to select the protocol as well?

@FedeAlonso
Copy link
Contributor Author

doesn't the UI requires to select the protocol as well?

Not on this tests

@FedeAlonso FedeAlonso merged commit 561bbd2 into red-hat-data-services:master Mar 7, 2024
12 checks passed
@FedeAlonso FedeAlonso deleted the fix/new_euntime_selection_dropdown_path_on_model_serving branch March 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jstourac jstourac jstourac approved these changes

@jgarciao jgarciao Awaiting requested review from jgarciao

@jiridanek jiridanek Awaiting requested review from jiridanek

@manosnoam manosnoam Awaiting requested review from manosnoam

@asanzgom asanzgom Awaiting requested review from asanzgom

Assignees
No one assigned
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedeAlonso @bdattoma @jstourac