fix rosa deployment #1232
Merged
fix rosa deployment #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
|
I don't see what's the actual fix and what's tidying up around. |
Thanks @jiridanek |
…data-services#1234) 1. when we exit with sys.exit(1) the line before should be log.error instead of log.info 2. format with f-string which is more readable 3. in the method execute_command(cmd) log the cmd and the output instead of doing that multiple times in the code I faced these issues as part of jira ticket: RHOAIENG-2683
kobihk
force-pushed
the
fix_rosa_deployment_master
branch
from
7a96e14 to
3081c29
Compare
|
jstourac
approved these changes
Feb 28, 2024
jiridanek
approved these changes
Feb 28, 2024
jgarciao
added
the
utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to jira ticket: RHOAIENG-2683