Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parity between Caikit+TGIS and TGIS standalone test suites #1218

Merged

Conversation

bdattoma
Copy link
Contributor

@bdattoma bdattoma commented Feb 19, 2024

  • duplicate the 420__model_serving/LLMs/422__model_serving_llm.robot suite
  • adjust it to use TGIS Standalone
  • fix tests which cannot be easily patched with adding/changing args (wip)

PR validation:

  1. rhods-ci-pr-test/2518 4 failures
  2. rhods-ci-pr-test/2519/ still failures
  3. rhods-ci-pr-test/2521 2/13 failures - 1 automation issue for sure, 1 still in doubt (tracked by RHOAIENG-3236)
    4. rhods-ci-pr-test/2523 re-run 2 previously failed tests PASS

@bdattoma bdattoma self-assigned this Feb 19, 2024
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Feb 19, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
423 0 0 423 100

@bdattoma bdattoma marked this pull request as ready for review February 20, 2024 16:49
@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Feb 21, 2024
@bdattoma bdattoma force-pushed the f/tgis-standalone-parity branch from 834c6e2 to 6123d9d Compare February 21, 2024 10:15
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdattoma bdattoma requested a review from lugi0 February 21, 2024 11:59
@bdattoma bdattoma merged commit db14531 into red-hat-data-services:master Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants