-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ODS-CI image with Python version arg = 3.11 #1216
Conversation
Signed-off-by: manosnoam <[email protected]>
|
Robot Results
|
@@ -60,9 +60,10 @@ RUN chmod +x ods_ci/build/run.sh &&\ | |||
COPY pyproject.toml . | |||
COPY poetry.lock . | |||
COPY README.md . | |||
RUN alternatives --install /usr/local/bin/python3 python3 /usr/bin/python${PYTHON_VERSION} 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be the only functional change in the PR. It looks ok to me in principle. It can break things, for example we will not have python3-distro
installed on python3.11, so if there's something that needs that package, it will break. But overall, feels reasonably safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure to run an entire Smoke job before merging it.
About distro, #817
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closing this one because it's not high in the priority queue, besides this is not causing issues.
hopefully this will remain true
Built and verified image by running: All tests (except bias tests that are not supported on 2.7) passed. |
For the record - this is a follow-up of #1213. |
ODS-CI image build output shows that the default Python version is now 3.11:
podman build -t ods-ci -f ods_ci/build/Dockerfile .