Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ODS-CI image with Python version arg = 3.11 #1216

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

manosnoam
Copy link
Contributor

@manosnoam manosnoam commented Feb 19, 2024

ODS-CI image build output shows that the default Python version is now 3.11:
podman build -t ods-ci -f ods_ci/build/Dockerfile .

STEP 43/49: RUN alternatives --install /usr/local/bin/python3 python3 /usr/bin/python${PYTHON_VERSION} 1
STEP 44/49: RUN python3 --version
Python 3.11.7
STEP 45/49: RUN curl -sSL https://install.python-poetry.org | python3 -
...
Poetry (1.7.1) is installed now. Great!
...
STEP 47/49: RUN poetry install
Creating virtualenv ods-ci-UC6Fl63A-py3.11 in /tmp/.cache/pypoetry/virtualenvs
...
Installing the current project: ods-ci (0.1.0)
...
Successfully tagged localhost/ods-ci:latest

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
405 0 0 405 100

@@ -60,9 +60,10 @@ RUN chmod +x ods_ci/build/run.sh &&\
COPY pyproject.toml .
COPY poetry.lock .
COPY README.md .
RUN alternatives --install /usr/local/bin/python3 python3 /usr/bin/python${PYTHON_VERSION} 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be the only functional change in the PR. It looks ok to me in principle. It can break things, for example we will not have python3-distro installed on python3.11, so if there's something that needs that package, it will break. But overall, feels reasonably safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure to run an entire Smoke job before merging it.

About distro, #817

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing this one because it's not high in the priority queue, besides this is not causing issues.

hopefully this will remain true

@manosnoam manosnoam added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Feb 19, 2024
@manosnoam
Copy link
Contributor Author

Built and verified image by running:
podman run --rm -v $PWD/.setup/test-variables.yml:/tmp/ods-ci/ods_ci/test-variables.yml:Z -v $PWD/ods_ci/test-output:/tmp/ods-ci/ods_ci/test-output:Z -e RUN_SCRIPT_ARGS='--skip-oclogin false --includ e Smoke' ods-ci:latest

All tests (except bias tests that are not supported on 2.7) passed.

@manosnoam manosnoam merged commit fcd4481 into red-hat-data-services:master Feb 19, 2024
11 checks passed
@jstourac
Copy link
Member

For the record - this is a follow-up of #1213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants