Fix 'Clean All Models Of Current User' KW #1203
Conversation
In case the current user does not have permissions to view other DS projects, then the Model Serving page does not include "select a project" link, which causes the 'Clean All Models Of Current User' KW to fail. The fix includes: - Skip cleanup if no Data Sciense projects exist - 'Set Up Project' SETUP KW continues if cleanup failed - 'Set Up Project' SETUP KW creates DS project only if doesn't exist yet Signed-off-by: manosnoam <[email protected]>
| END | ||
| Open Data Science Projects Home Page | ||
| Wait For RHODS Dashboard To Load wait_for_cards=${FALSE} expected_page=Data Science Projects |
There was a problem hiding this comment.
Because Open Data Science Projects Home Page already does it :)
And regarding
Create Data Science Project title=${namespace} description=kserve test project existing_project=${TRUE}
I did it since that's what the KW docstring says:
Set Up Project
[Documentation] Creates the DS Project (if not exists)
There was a problem hiding this comment.
Because Open Data Science Projects Home Page already does it :)
Ok
I wasn't questioning the create DS project part :)
Robot Results
|
manosnoam
added
verified
|
|
@bdattoma I've also verify the fix by running another suite that uses 'Clean All Models Of Current User' KW at suite's Setup and Teardown, and it works as expected: The failed test (Verify Secure Model Can Be Deployed In Same Project) is due to a recent product bug: https://issues.redhat.com/browse/RHOAIENG-2759 |
| END | ||
| Open Data Science Projects Home Page | ||
| Wait For RHODS Dashboard To Load wait_for_cards=${FALSE} expected_page=Data Science Projects | ||
| Create Data Science Project title=${namespace} description=kserve test project | ||
| Create Data Science Project title=${namespace} description=kserve test project existing_project=${TRUE} |
There was a problem hiding this comment.
This is the only line I'm not sure about, specifically existing_project=${TRUE}.
Could you test the change against 422__model_serving_caikit_py_client.robot, 422__model_serving_llm_other_runtimes_UI.robot and 422__model_serving_llm_UI.robot?
In case the current user does not have permissions to view other DS projects, then the Model Serving page does not include "select a project" link, which causes the 'Clean All Models Of Current User' KW to fail.
The fix includes: