Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another fix to Wait Until Csv Is Ready keyword #1195

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Another fix to Wait Until Csv Is Ready keyword #1195

merged 1 commit into from
Feb 13, 2024

Conversation

manosnoam
Copy link
Contributor

@manosnoam manosnoam commented Feb 13, 2024 •
edited
Loading

Fixing the oc wait command that ended too soon for RHODS operator CSV verification in previous PR #1191 .

This is the output after the fix:
image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
401 0 0 401 100

@manosnoam manosnoam added verified This PR has been tested with Jenkins ⚠️ high priority review I need this to be reviewed ASAP labels Feb 13, 2024
jstourac
jstourac approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from mobile just to unblock us. I would rather welcome a simple revert and do a proper check tomorrow on PC.

Anyway, if this is tested properly, please go ahead.

@manosnoam manosnoam merged commit 3bac0f7 into red-hat-data-services:master Feb 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac approved these changes

@jiridanek jiridanek jiridanek approved these changes

@kobihk kobihk Awaiting requested review from kobihk

Assignees
No one assigned
Labels
verified This PR has been tested with Jenkins ⚠️ high priority review I need this to be reviewed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manosnoam @jiridanek @jstourac