Update runtime yamls #1182
Merged
Update runtime yamls #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdattoma
added
needs testing
|
PR validation (OLD):
|
Robot Results
|
|
you need to update the link in description properly :) |
bdattoma
added
verified
|
PR Validation after image URL changes:
|
bdattoma
force-pushed
the
update_runtimes
branch
from
86a6fe0 to
fbaa264
Compare
bdattoma
force-pushed
the
update_runtimes
branch
from
fbaa264 to
d608d19
Compare
bdattoma
added
verified
|
FedeAlonso
approved these changes
Feb 15, 2024
jstourac
reviewed
Feb 15, 2024
| # resources: # configure as required | ||
| # requests: | ||
| # cpu: 8 | ||
| # memory: 16Gi |
There was a problem hiding this comment.
Are these two commented blocks for resources in these two files necessary to keep?
There was a problem hiding this comment.
i want to keep the manifest equal to the one published upstream, apart from image url which must change
jstourac
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning our caikit+tgis runtime yaml with https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/custom-manifests/caikit/caikit-tgis/caikit-tgis-servingruntime-grpc.yaml
UPDATE: there will be a slight additional update to the manifest opendatahub-io/caikit-tgis-serving#217. So I would wait merging this test PR until we include the new changes