Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log gather when pod doesn't get ready by timeout #1179

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

bdattoma
Copy link
Contributor

@bdattoma bdattoma commented Feb 6, 2024

When Wait For Pods To Be Ready hits the timeout, we can't tell why it happened. So, trying to get clear info by capturing pod logs and namespace events (on failure only)

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Feb 6, 2024
@bdattoma bdattoma self-assigned this Feb 6, 2024
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Dismissed Show dismissed Hide dismissed
ods_ci/tests/Resources/OCP.resource Dismissed Show dismissed Hide dismissed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
406 0 0 406 100

@bdattoma
Copy link
Contributor Author

bdattoma commented Feb 6, 2024

PR validation

  1. Bunch of tests leveraging on the keyword (for regression): rhods-ci-pr-test/2421 PASS
  2. Simulating failure (from local) in a Model Serving test:
    image

jstourac
jstourac previously approved these changes Feb 6, 2024
jiridanek
jiridanek previously approved these changes Feb 6, 2024
@bdattoma bdattoma dismissed stale reviews from jiridanek and jstourac via a51fd54 February 6, 2024 15:13
ods_ci/tests/Resources/OCP.resource Fixed Show resolved Hide resolved
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Dismissed Show dismissed Hide dismissed
jstourac
jstourac previously approved these changes Feb 6, 2024
@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Feb 6, 2024
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdattoma bdattoma merged commit 17a6e77 into red-hat-data-services:master Feb 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants