Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test some LLM UI tests from Smoke #1170

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Fix test some LLM UI tests from Smoke #1170

merged 7 commits into from
Feb 1, 2024

Conversation

bdattoma
Copy link
Contributor

No description provided.

@bdattoma bdattoma self-assigned this Jan 31, 2024
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Jan 31, 2024
@bdattoma
Copy link
Contributor Author

bdattoma commented Jan 31, 2024 •
edited
Loading

PR validation: rhods-ci-pr-test/2412 PASS

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
406 0 0 406 100

FedeAlonso
FedeAlonso previously approved these changes Jan 31, 2024
View reviewed changes
@jstourac
Copy link
Member

There are still some failures in the CI run. Is it expected?

lugi0
lugi0 previously approved these changes Jan 31, 2024
View reviewed changes
@bdattoma
Copy link
Contributor Author

There are still some failures in the CI run. Is it expected?

I'm looking into them, metrics related..trying to fixing

@bdattoma bdattoma changed the title Fix test setup for some LLM UI tests Fix test some LLM UI tests from Smoke Jan 31, 2024
@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jan 31, 2024
@bdattoma bdattoma requested review from FedeAlonso and lugi0 January 31, 2024 16:57
@bdattoma bdattoma merged commit 9346076 into red-hat-data-services:master Feb 1, 2024
8 of 9 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeAlonso FedeAlonso FedeAlonso approved these changes

@jstourac jstourac jstourac approved these changes

@aloganat aloganat Awaiting requested review from aloganat

@nehachopra27 nehachopra27 Awaiting requested review from nehachopra27

@tarukumar tarukumar Awaiting requested review from tarukumar

@lugi0 lugi0 Awaiting requested review from lugi0

Assignees

@bdattoma bdattoma

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdattoma @jstourac @FedeAlonso @lugi0