Fix the broken dryrun tests with Trusty deployment #1159
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ... label_selector=app.kubernetes.io/part-of=kserve | ||
| ${containerNames} = Create List kube-rbac-proxy manager | ||
| ... label_selector=app.kubernetes.io/part-of=trustyai | ||
| ${containerNames} = Create List manager |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
nehachopra27
force-pushed
the
broken
branch
2 times, most recently
from
51fcff6 to
62cb486
Compare
| @@ -27,7 +27,8 @@ | |||
| [Tags] Smoke | |||
| ... Tier1 | |||
| ... ODS-173 | |||
| Run OpenShift Metrics Query ${METRIC_RHODS_UNDEFINED} retry_attempts=1 | |||
| Run OpenShift Metrics Query ${METRIC_RHODS_UNDEFINED} username=${OCP_ADMIN_USER.USERNAME} password=${OCP_ADMIN_USER.PASSWORD} | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| @@ -46,7 +47,8 @@ | |||
| ... ODS-634 | |||
| ... Tier1 | |||
| Skip If RHODS Is Self-Managed | |||
| ${value} = Run OpenShift Metrics Query query=rhods_total_users | |||
| ${value} = Run OpenShift Metrics Query query=rhods_total_users username=${OCP_ADMIN_USER.USERNAME} password=${OCP_ADMIN_USER.PASSWORD} | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| @@ -61,8 +63,8 @@ | |||
| Skip If RHODS Is Self-Managed | |||
|
|
|||
| ${value_openshift_observe} = Run OpenShift Metrics Query | |||
| ... query=rhods_aggregate_availability | |||
| ... retry_attempts=1 return_zero_if_result_empty=False | |||
| ... query=rhods_aggregate_availability username=${OCP_ADMIN_USER.USERNAME} password=${OCP_ADMIN_USER.PASSWORD} | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| @@ -111,7 +114,8 @@ | |||
| Log In N Users To JupyterLab And Launch A Notebook For Each Of Them | |||
| ... list_of_usernames=${list_of_usernames} | |||
| Sleep 60s reason=Wait until metrics are available | |||
| ${value} = Run OpenShift Metrics Query query=cluster:usage:consumption:rhods:pod:up | |||
| ${value} = Run OpenShift Metrics Query query=cluster:usage:consumption:rhods:pod:up username=${OCP_ADMIN_USER.USERNAME} password=${OCP_ADMIN_USER.PASSWORD} | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
ods_ci/tests/Tests/100__deploy/100__installation/111__trustyai.robot
Outdated
Show resolved
Hide resolved
ods_ci/tests/Tests/100__deploy/100__installation/111__trustyai.robot
Outdated
Show resolved
Hide resolved
jgarciao
added
the
enhancements
|
|
Since we're touching this code - these robocop warnings about line lengths could be easily avoided in those cases, do you mind to update these? Also, could you confirm this has been tested with a successful run? |
| ... namespace=${APPLICATIONS_NAMESPACE} exp_replicas=1 | ||
| Verify TrustyAI Operator Deployment | ||
| [Documentation] Verifies the deployment of the trustyai operator in the Applications namespace | ||
| Wait For Pods Number 1 |
There was a problem hiding this comment.
The Operator name was changed from now and when the PR was written and it was failing. Fixed it now. Works fine.
There was a problem hiding this comment.
ok but why changing the kw?
There was a problem hiding this comment.
kW title has been changed.
There was a problem hiding this comment.
okay, but way changing from Wait For Pods To Be Ready to Wait For Pods Number?
No description provided.