Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial logging update attempt and increase of timeout #1155

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Jan 25, 2024

  • logging update to make it slightly clearer
  • increase of the timeout for the provision and claim check from 5 to 10
    minutes

I don't think this one needs a CI run.

Please let me know whether you think it can be a bit clearer to somebody who's not familiar with the code itself.

@jstourac jstourac requested a review from manosnoam January 25, 2024 06:55
@jstourac jstourac self-assigned this Jan 25, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
401 0 0 401 100

@jstourac jstourac force-pushed the loggingHive branch 2 times, most recently from c57fac8 to d56e98a Compare January 25, 2024 08:36
@jstourac jstourac changed the title Trivial logging update attempt to make it slightly clearer Trivial logging update attempt and increase of timeout Jan 25, 2024
- logging update to make it slightly clearer
- increase of the timeout for the provision and claim check from 5 to 10
  minutes
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@jgarciao jgarciao added enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) do not merge Do not merge this yet please labels Jan 25, 2024
@manosnoam manosnoam merged commit fd004a3 into red-hat-data-services:master Jan 25, 2024
11 checks passed
@jstourac jstourac deleted the loggingHive branch January 25, 2024 16:20
@jgarciao jgarciao removed the do not merge Do not merge this yet please label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants