-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI testing for TGIS Standalone #1151
Conversation
*** Variables *** | ||
${LLM_RESOURCES_DIRPATH}= ods_ci/tests/Resources/Files/llm | ||
${TEST_NS}= runtimes-ui | ||
${EXP_RESPONSES_FILEPATH}= ${LLM_RESOURCES_DIRPATH}/model_expected_responses.json |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
${TEST_NS}= runtimes-ui | ||
${EXP_RESPONSES_FILEPATH}= ${LLM_RESOURCES_DIRPATH}/model_expected_responses.json | ||
${FLAN_MODEL_S3_DIR}= flan-t5-small/flan-t5-small-hf | ||
${FLAN_STORAGE_URI}= s3://${S3.BUCKET_3.NAME}/${FLAN_MODEL_S3_DIR}/ |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
...ts/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_other_runtimes_UI.robot
Fixed
Show fixed
Hide fixed
...ts/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_other_runtimes_UI.robot
Fixed
Show fixed
Hide fixed
${test_namespace}= Set Variable ${TEST_NS} | ||
${isvc__name}= Set Variable flan-t5-small-hf-gpu | ||
${model_name}= Set Variable flan-t5-small-hf | ||
${requests}= Create Dictionary nvidia.com/gpu=1 |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
Robot Results
|
PR validation:
Dry-run failing for changes not introduced with this PR |
[Documentation] Basic tests leveraging on a non-admin user for preparing, deploying and querying a LLM model | ||
... using Single-model platform and TGIS Standalone runtime. | ||
[Tags] Sanity Tier1 ODS-2611 | ||
[Setup] Run git clone https://github.com/IBM/text-generation-inference/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the git repo already exists ? I think clone will fail if text-generation-inference already
dir exists
Shouldn't the repo cloned at suite setup, maybe to be used by other tests as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clone will fail but won't fail the test
[Documentation] Basic tests for preparing, deploying and querying a LLM model on GPU node | ||
... using Single-model platform and TGIS Standalone runtime. | ||
[Tags] Sanity Tier1 ODS-2612 Resources-GPU | ||
[Setup] Run git clone https://github.com/IBM/text-generation-inference/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another clone of text-generation-inference
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. The idea around this suite is to put tests about more basic tests for serving runtimes which will come. Not all of them will need the same repos. So I clone it again here
|
2aba488
into
red-hat-data-services:master
Adding 2 new e2e UI tests for TGIS Standalone serving runtime: with and without GPU node