Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI testing for TGIS Standalone #1151

Merged
merged 19 commits into from
Jan 26, 2024

Conversation

bdattoma
Copy link
Contributor

Adding 2 new e2e UI tests for TGIS Standalone serving runtime: with and without GPU node

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Jan 23, 2024
@bdattoma bdattoma self-assigned this Jan 23, 2024
*** Variables ***
${LLM_RESOURCES_DIRPATH}= ods_ci/tests/Resources/Files/llm
${TEST_NS}= runtimes-ui
${EXP_RESPONSES_FILEPATH}= ${LLM_RESOURCES_DIRPATH}/model_expected_responses.json

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${EXP_RESPONSES_FILEPATH}' is assigned but not used
${TEST_NS}= runtimes-ui
${EXP_RESPONSES_FILEPATH}= ${LLM_RESOURCES_DIRPATH}/model_expected_responses.json
${FLAN_MODEL_S3_DIR}= flan-t5-small/flan-t5-small-hf
${FLAN_STORAGE_URI}= s3://${S3.BUCKET_3.NAME}/${FLAN_MODEL_S3_DIR}/

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${FLAN_STORAGE_URI}' is assigned but not used
${test_namespace}= Set Variable ${TEST_NS}
${isvc__name}= Set Variable flan-t5-small-hf-gpu
${model_name}= Set Variable flan-t5-small-hf
${requests}= Create Dictionary nvidia.com/gpu=1

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/OCP.resource Fixed Show fixed Hide fixed
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
403 0 0 403 100

@bdattoma
Copy link
Contributor Author

bdattoma commented Jan 24, 2024

PR validation:

  • TGIS standalone UI test: rhods-ci-pr-test/2377/ Failed in teardown, re-trying after increasing the project deletion timeout rhods-ci-pr-test/2379/ PASS
  • TGIS standalone UI test on GPU: rhods-ci-pr-test/2378/ PASS

Dry-run failing for changes not introduced with this PR

@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jan 24, 2024
[Documentation] Basic tests leveraging on a non-admin user for preparing, deploying and querying a LLM model
... using Single-model platform and TGIS Standalone runtime.
[Tags] Sanity Tier1 ODS-2611
[Setup] Run git clone https://github.com/IBM/text-generation-inference/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the git repo already exists ? I think clone will fail if text-generation-inference already dir exists
Shouldn't the repo cloned at suite setup, maybe to be used by other tests as well ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the clone will fail but won't fail the test

[Documentation] Basic tests for preparing, deploying and querying a LLM model on GPU node
... using Single-model platform and TGIS Standalone runtime.
[Tags] Sanity Tier1 ODS-2612 Resources-GPU
[Setup] Run git clone https://github.com/IBM/text-generation-inference/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another clone of text-generation-inference...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. The idea around this suite is to put tests about more basic tests for serving runtimes which will come. Not all of them will need the same repos. So I clone it again here

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdattoma bdattoma merged commit 2aba488 into red-hat-data-services:master Jan 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants