New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pipeline upstream tests in ods-ci #1144

Merged

diegolovison merged 5 commits into red-hat-data-services:master from diegolovison:e2e_upstream_pipe

Feb 12, 2024

Contributor

diegolovison commented Jan 22, 2024 •

edited

Loading

rhods-smoke/4558

The repo and branch are fixed for RHOAI 2.7

github-advanced-security bot found potential problems

View reviewed changes

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

Contributor

github-actions bot commented Jan 22, 2024 •

edited

Loading

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
401	0	0	401	100

diegolovison added needs testing new test labels

diegolovison force-pushed the e2e_upstream_pipe branch from 261bb3f to ea2778c Compare

January 23, 2024 14:27

diegolovison removed the needs testing label

jgarciao reviewed

View reviewed changes

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

jgarciao reviewed

View reviewed changes

...shboard/430__data_science_pipelines/test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

diegolovison force-pushed the e2e_upstream_pipe branch from ea2778c to afc323f Compare

February 9, 2024 15:29

github-advanced-security bot found potential problems

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

    
                  ...     DataSciencePipelines

                  ${openshift_api}    Get Openshift Server

                  Log    ${openshift_api}

                  ${return_code}    ${output}    Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && make integrationtest K8SAPISERVERHOST=${openshift_api} DSPANAMESPACE=${DSPANAMESPACE} KUBECONFIGPATH=${KUBECONFIGPATH}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (234/120)

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

    
              *** Keywords ***

              Prepare Data Science Pipelines Operator E2E Test Suite

                  [Documentation]    Prepare Data Science Pipelines Operator E2E Test Suite

                  ${return_code}    ${output}     Run And Return Rc And Output    rm -fR ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning test

Local variable '${return_code}' is overwritten before usage

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

    
                  [Documentation]    Prepare Data Science Pipelines Operator E2E Test Suite

                  ${return_code}    ${output}     Run And Return Rc And Output    rm -fR ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}

                  Log    ${output}

                  ${return_code}    ${output}     Run And Return Rc And Output    git clone ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (168/120)

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

    
                      FAIL    Cannot create a new project ${DSPANAMESPACE}

                  END

              Teardown Data Science Pipelines Operator E2E Test Suite

Check warning

Code scanning / Robocop

Missing documentation in '{{ name }}' keyword Warning test

Missing documentation in 'Teardown Data Science Pipelines Operator E2E Test Suite' keyword

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

    
                  END

              Teardown Data Science Pipelines Operator E2E Test Suite

                  ${return_code}    ${output}     Run And Return Rc And Output    oc delete project ${DSPANAMESPACE} --force --grace-period=0

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (127/120)

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

    
                  END

              Teardown Data Science Pipelines Operator E2E Test Suite

                  ${return_code}    ${output}     Run And Return Rc And Output    oc delete project ${DSPANAMESPACE} --force --grace-period=0

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${return_code}' is assigned but not used


          Run pipeline upstream tests in ods-ci

b773d15

diegolovison force-pushed the e2e_upstream_pipe branch from afc323f to b773d15 Compare

February 9, 2024 16:20

jgarciao self-requested a review

February 9, 2024 16:21

jgarciao previously approved these changes

View reviewed changes

jgarciao requested a review from jstourac

February 9, 2024 16:31

jgarciao added the verified label

jgarciao requested a review from bdattoma

February 9, 2024 16:32

bdattoma reviewed

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Show resolved Hide resolved


          Delete Data Science Project From CLI

0066cb2

diegolovison dismissed jgarciao’s stale review via

0066cb2

February 12, 2024 12:10

github-advanced-security bot found potential problems

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

bdattoma reviewed

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

bdattoma previously approved these changes

View reviewed changes


          inline

5d72423

diegolovison dismissed bdattoma’s stale review via

5d72423

February 12, 2024 13:17

github-advanced-security bot found potential problems

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

		@@ -0,0 +1,52 @@
		* Settings *

Check warning

Code scanning / Robocop

Inconsistent use of tabs and spaces in file Warning test

Inconsistent use of tabs and spaces in file

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

+                  ${return_code}    ${output}     Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && git checkout -b it_test ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}
+                  Should Be Equal As Integers	${return_code}	 0  msg=Unable to checkout data-science-pipelines-operator
+                  RHOSi Setup
+                  ${rc}    ${out}=    Run And Return Rc And Output    oc new-project ${DSPANAMESPACE}

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected '' but got '=' instead

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

+                  ${return_code}    ${output}     Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && git checkout -b it_test ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}
+                  Should Be Equal As Integers	${return_code}	 0  msg=Unable to checkout data-science-pipelines-operator
+                  RHOSi Setup
+                  ${rc}    ${out}=    Run And Return Rc And Output    oc new-project ${DSPANAMESPACE}

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${out}' is assigned but not used

bdattoma approved these changes

View reviewed changes

bdattoma previously approved these changes

View reviewed changes

lugi0 reviewed

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot Outdated Show resolved Hide resolved


          space

affdea1

diegolovison dismissed bdattoma’s stale review via

affdea1

February 12, 2024 16:25

github-advanced-security bot found potential problems

View reviewed changes

...rd/430__data_science_pipelines/436__test-run-data-science-pipelines-operator-e2e-tests.robot

+                  Log    ${output}
+                  ${return_code}    ${output}     Run And Return Rc And Output    git clone ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
+                  Log    ${output}
+                  Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (254/120)


          space

31da789

lugi0 approved these changes

View reviewed changes

sonarqubecloud bot commented Feb 12, 2024

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bdattoma approved these changes

View reviewed changes

diegolovison merged commit f3ba5d5 into red-hat-data-services:master

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aloganat aloganat left review comments

lugi0 lugi0 approved these changes

bdattoma bdattoma approved these changes

jgarciao jgarciao left review comments

jstourac Awaiting requested review from jstourac

Labels

new test verified