Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library versions tests #1143

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Fix library versions tests #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6bfe52b
fix popup closing
lugi0 Jan 22, 2024
7a8ddaa
Merge branch 'master' into fix/jupyter_libraries_metadata
lugi0 Jan 22, 2024
98a2938
add workaround for missing jupyter title in card
lugi0 Jan 23, 2024
869f9d6
workaround for the wrong capitalization in the tensorflow image
lugi0 Jan 23, 2024
114c451
fix typo
lugi0 Jan 23, 2024
812c64a
add warning if name is all lowercase
lugi0 Jan 23, 2024
578fa57
Merge branch 'master' into fix/jupyter_libraries_metadata
lugi0 Jan 23, 2024
60b153c
Merge branch 'master' into fix/jupyter_libraries_metadata
lugi0 Jan 25, 2024
85e6415
remove workaround for jupyter tile
lugi0 Jan 25, 2024
70b7152
update xpath to remove patternfly version
lugi0 Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ Fetch Image Tooltip Info
${item} = Get Text ${xpath_tooltip_items}\[${index}]
Append To List ${tmp_list} ${item}
END
Click Element xpath://div[@class='pf-v5-c-popover__content']/button[@aria-label="Close"]
Click Element xpath://div[contains(@class,'popover__close')]/button[@aria-label="Close"]
RETURN ${tmp_list}

Spawn Notebooks And Set S3 Credentials
Expand Down
7 changes: 6 additions & 1 deletion ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,11 +410,16 @@ Check Versions In JupyterLab
END
ELSE IF "${libDetail}[0]" == "Python"
${status} = Python Version Check ${libDetail}[1]
ELSE IF "${libDetail}[0]" == "Sklearn-onnx"
# lowercase string is needed as a workaround for the metadata of the tensorflow image
Fixed Show fixed Hide fixed
Dismissed Show dismissed Hide dismissed
# needs to be updated when https://issues.redhat.com/browse/RHOAIENG-2124 is resolved
Dismissed Show dismissed Hide dismissed
ELSE IF "${libDetail}[0]" == "Sklearn-onnx" or "${libDetail}[0]" == "sklearn-onnx"
${status} ${value} = Verify Installed Library Version skl2onnx ${libDetail}[1]
IF '${status}' == 'FAIL'
${return_status} = Set Variable FAIL
END
IF "${libDetail}[0]" == "sklearn-onnx"
Log Library name "${libDetail}[0]" is in all lowercase level=WARN
END
ELSE IF "${libDetail}[0]" == "MySQL Connector/Python"
${status} ${value} = Verify Installed Library Version mysql-connector-python ${libDetail}[1]
IF '${status}' == 'FAIL'
Expand Down
Loading