New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Dashboard automation errors for 2.6 pt1 #1132

Merged

FedeAlonso merged 22 commits into red-hat-data-services:master from FedeAlonso:fix/dashboard_tests_2_6

Jan 24, 2024

Contributor

FedeAlonso commented Jan 18, 2024 •

edited by jstourac

Loading

Test fixed:

ODS-1402: Verify Quick Starts Work When All Steps Are Skipped
ODS-1305: Verify External Links In Quick Starts Are Not Broken
ODS-489: Verify Filters Are Working On Resources Page
ODS-1661: Verify RHODS Accept Multiple Admin Groups And CRD Gets Updates
ODS-1680: Verify Unauthorized User Is Not Able To Spawn Jupyter Notebook
ODS-1686: Verify Automatically Detects a Group Selected Is Removed and Notify the User
ODS-1825: Verify User Can Create A S3 Data Connection And Connect It To Workbenches
ODS-1864: Verify User Can Create A Workbench With Environment Variables
ODS-1868: Verify User Can Access Only Its Owned Projects
ODS-2202: Verify User Can Modify And Revoke Access To DS Projects From Other Users
ODS-2208: Verify User Can Assign Access Permissions To User Groups

FedeAlonso added 2 commits

January 18, 2024 18:03


          fix test ODS-1402: Verify Quick Starts Work When All Steps Are Skipped

e842585


          fix test ODS-1305: Verify External Links In Quick Starts Are Not Broken

72b7379

FedeAlonso added the do not merge label

Contributor

github-actions bot commented Jan 18, 2024 •

edited

Loading

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
401	0	0	401	100

FedeAlonso added 2 commits

January 19, 2024 07:31


          fix test ODS-489: Verify Filters Are Working On Resources Page

7f1174a


          test ODS-1661: Verify RHODS Accept Multiple Admin Groups And CRD Gets…

7e1de84

… Updates

github-advanced-security bot found potential problems

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardSettings.resource

    
                  FOR    ${admin_group}    IN    @{admin_groups}

                           ${present}=  Run Keyword And Return Status    Element Should Be Visible   //*[@class="pf-c-select__menu-item pf-m-selected" and contains(text(), "${admin_group}")]

                           ${present}=  Run Keyword And Return Status    Element Should Be Visible   //button[@role="option" and text()="${admin_group}" and @aria-selected="true"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (165/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardSettings.resource

    
                  FOR    ${user_group}    IN    @{user_groups}

                          ${present}=  Run Keyword And Return Status

                             ...  Element Should Be Visible   //*[@class="pf-c-select__menu-item pf-m-selected" and contains(text(), "${user_group}")]

                             ...  Element Should Be Visible   //button[@role="option" and text()="${user_group}" and @aria-selected="true"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (125/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardSettings.resource

    
                  FOR    ${user_group}    IN    @{user_groups}

                          ${present}=  Run Keyword And Return Status

                             ...  Element Should Be Visible   //*[@class="pf-c-select__menu-item pf-m-selected" and contains(text(), "${user_group}")]

                             ...  Element Should Be Visible   //button[@role="option" and text()="${user_group}" and @aria-selected="true"]

Check warning

Code scanning / Robocop

Continuation marker should be aligned with starting row Warning test

Continuation marker should be aligned with starting row

FedeAlonso added 2 commits

January 19, 2024 12:16


          delete pf version from paths and validate ODS-1680

d5b6700


          Merge branch 'master' of github.com:red-hat-data-services/ods-ci into…

8fb32d2

… fix/dashboard_tests_2_6

github-advanced-security bot found potential problems

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ResourcesPage.resource

    
            @@ -41,7 +41,7 @@
          
                  [Arguments]    ${expected_number}

                  ${version_check}=  Is RHODS Version Greater Or Equal Than  1.21.0

                  IF  ${version_check}==True

                      ${versioned_title_xp}=    Set Variable    //div[@class="pf-c-card__title"]/div[@class="pf-c-content"]

                      ${versioned_title_xp}=    Set Variable    //div[contains(@class, "-c-card__title")]//div[contains(@class, "-c-content")]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (128/120)

FedeAlonso added 5 commits

January 19, 2024 12:44


          test ODS-1686: Verify Automatically Detects a Group Selected Is Remov…

31cc673

…ed and Notify the User


          add logs to POST Dashboard API requests

9055c47


          fix test ODS-1825: Verify User Can Create A S3 Data Connection And Co…

…nnect It To Workbenches


          fix test ODS-1864: Verify User Can Create A Workbench With Environmen…

bed81ef

…t Variables


          Merge branch 'master' into fix/dashboard_tests_2_6

2d22a5a

github-advanced-security bot found potential problems

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource

    
            @@ -122,19 +122,13 @@
          
                              Log   ${pair_idx}-${key}-${value}

                              Run Keyword And Continue On Failure    Wait Until Page Contains Element

                              ...    xpath=//input[@aria-label="key of item ${pair_idx}"]

                              Input Text    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${idx}]//input[@aria-label="key of item ${pair_idx}"]

                              Input Text    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${idx}]//input[@aria-label="key of item ${pair_idx}"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (145/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource

    
                              ...           ${key}

                              Input Text    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${idx}]//input[@aria-label="value of item ${pair_idx}"]

                              Input Text    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${idx}]//input[@aria-label="value of item ${pair_idx}"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (147/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource

-                                  ELSE IF    "${add_key_value_text}" == "Add another variable"
-                                      Execute Javascript    document.getElementsByClassName("pf-c-drawer__content")[1].scrollBy(0,700)  # robocop: disable
-                                  END
+                                  Click Element    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${idx}]//button[text()="${add_key_value_text}"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (146/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource

@@ @@ -168,13 +162,13 @@ @@
                   [Documentation]    Selects the type of environment variable in the workbench creation page: Secret vs Config Map
                   [Arguments]    ${k8s_type}    ${input_type}    ${variable_index}
                   Run Keyword And Continue On Failure    Wait Until Page Contains Element
-                  ...    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${variable_index}]//div[@class="pf-l-stack__item"]/div[contains(@class,"pf-c-select")]/button
-                  Click Element    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${variable_index}]//div[contains(@class,"pf-c-select")]/button
+                  ...    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${variable_index}]//button[@aria-label="Options menu"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (127/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource

    
                  ...    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${variable_index}]//div[@class="pf-l-stack__item"]/div[contains(@class,"pf-c-select")]/button

                  Click Element    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${variable_index}]//div[contains(@class,"pf-c-select")]/button

                  ...    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${variable_index}]//button[@aria-label="Options menu"]

                  Click Element    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${variable_index}]//button[@aria-label="Options menu"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (137/120)

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource

    
                  Wait Until Page Contains Element    xpath=//ul[@role="listbox"]/li/button[text()="${k8s_type}"]

                  Click Element    xpath=//ul[@role="listbox"]/li/button[text()="${k8s_type}"]

                  Run Keyword And Continue On Failure

                  ...    Wait Until Page Contains Element    ${ENV_VARIABLES_SECTION_XP}//button[div/span[text()="Select one"]]

                  Click Element    ${ENV_VARIABLES_SECTION_XP}/div[@class="pf-l-split"][${variable_index}]//button[div/span[text()="Select one"]]

                  Click Element    ${ENV_VARIABLES_SECTION_XP}/div[contains(@class, "-l-split")][${variable_index}]//button[div/span[text()="Select one"]]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (140/120)

FedeAlonso added 2 commits

January 22, 2024 07:58


          Merge branch 'master' into fix/dashboard_tests_2_6

7e8cb1e


          fix test ODS-2202: Verify User Can Access Only Its Owned Projects

bd87ff2

FedeAlonso changed the title ~~Fix: Dashboard automation errors for 2.6~~ Fix: Dashboard automation errors for 2.6 pt1

FedeAlonso added needs testing and removed do not merge labels

FedeAlonso marked this pull request as ready for review

January 22, 2024 11:13

FedeAlonso requested review from jgarciao, jiridanek, jstourac, lugi0 and bdattoma

January 22, 2024 11:13

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardResources.resource Outdated Show resolved Hide resolved


          Merge branch 'master' into fix/dashboard_tests_2_6

fad1461

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardAPI.resource Outdated Show resolved Hide resolved

bdattoma reviewed

View reviewed changes

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource Outdated

Comment on lines 133 to 137

-                                  IF    "${add_key_value_text}" == "Add another key / value pair"
-                                      Execute Javascript    document.getElementsByClassName("pf-c-drawer__content")[1].scrollBy(0,500)  # robocop: disable
-                                  ELSE IF    "${add_key_value_text}" == "Add another variable"
-                                      Execute Javascript    document.getElementsByClassName("pf-c-drawer__content")[1].scrollBy(0,700)  # robocop: disable
-                                  END

Contributor

bdattoma Jan 23, 2024

I think this might be still needed in case of many env variables, try running ODS-2595 for example

Contributor Author

FedeAlonso Jan 23, 2024

I'm not just deleting it, I'm navigating using the left bar menu, instead of usin js scripts

Contributor

bdattoma Jan 23, 2024 •

edited

Loading

I see that and it's correct, but it might not be enough when the variables are many. Pls try with ODS-2595

Contributor Author

FedeAlonso Jan 24, 2024

Added "do not merge" label until everything related with this is properly tested and or fixed

Contributor Author

FedeAlonso Jan 24, 2024

Just using the navigation when creating multiple env vars does not work properly.
I've restored the script and modified it in order to make it work with the new UI

Contributor Author

FedeAlonso Jan 24, 2024

@bdattoma Can you please check the last changes? If you are OK with the new script I will merge this PR

Contributor

bdattoma Jan 24, 2024

I still see the script deleted

Contributor Author

FedeAlonso Jan 24, 2024

🤦 my bad....
@bdattoma can you re review?


          Merge branch 'master' into fix/dashboard_tests_2_6

173864a

jiridanek added the enhancements label

FedeAlonso added 4 commits

January 23, 2024 12:29


          close all browsers befor ODS-1868

3c149b5


          PR fixes

941767b


          Merge branch 'master' into fix/dashboard_tests_2_6

197ee51


          Merge branch 'master' of github.com:red-hat-data-services/ods-ci into…

4fd3e59

… fix/dashboard_tests_2_6

Contributor Author

FedeAlonso commented Jan 24, 2024 •

edited

Loading

Test execution results:

	              Total	Failed	Passed	Skipped	Pass %
Critical tests	0	0	0	0	100.0
All tests	12	0	12	0	100.0

rhods-smoke/4422/

bdattoma previously approved these changes

View reviewed changes

jstourac previously approved these changes

View reviewed changes

FedeAlonso added the do not merge label


          Fix script issue

ad4c545

FedeAlonso added verified and removed do not merge labels

FedeAlonso requested a review from bdattoma

January 24, 2024 11:12

jiridanek previously approved these changes

View reviewed changes

FedeAlonso removed the needs testing label


          Fix script issue

6a51b40

FedeAlonso dismissed stale reviews from jiridanek, bdattoma, and jstourac via

6a51b40

January 24, 2024 16:25


          Merge branch 'master' into fix/dashboard_tests_2_6

2e4a115

sonarqubecloud bot commented Jan 24, 2024

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jiridanek approved these changes

View reviewed changes

bdattoma approved these changes

View reviewed changes

FedeAlonso merged commit b63590e into red-hat-data-services:master

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bdattoma bdattoma approved these changes

jiridanek jiridanek approved these changes

jstourac jstourac left review comments

jgarciao Awaiting requested review from jgarciao

lugi0 Awaiting requested review from lugi0

Labels

enhancements verified