Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance "Verify That XXXXXX Image Is A CPaaS Built Image" tests #1131

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Enhance "Verify That XXXXXX Image Is A CPaaS Built Image" tests #1131

merged 4 commits into from
Jan 22, 2024

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented Jan 18, 2024 •
edited
Loading

Tests were failing sometimes because prometheus pod wasn't running yet after installation. Adding a wait until the prometheus pod is running

@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Jan 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
398 0 0 398 100

asanzgom
asanzgom previously approved these changes Jan 18, 2024
View reviewed changes
@jgarciao jgarciao requested a review from bdattoma January 22, 2024 08:53
@jgarciao jgarciao added the verified This PR has been tested with Jenkins label Jan 22, 2024
jstourac
jstourac previously approved these changes Jan 22, 2024
View reviewed changes
@jgarciao jgarciao dismissed stale reviews from jstourac and asanzgom via 1e55f62 January 22, 2024 10:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao
Copy link
Contributor Author

Tested successfully in local and rhods-ci-pr-test/2351 (only oauth-proxy test, as the others were skipped)

@jgarciao jgarciao merged commit 8a17978 into red-hat-data-services:master Jan 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac approved these changes

@bdattoma bdattoma bdattoma approved these changes

@mattmahoneyrh mattmahoneyrh Awaiting requested review from mattmahoneyrh

@asanzgom asanzgom Awaiting requested review from asanzgom

Assignees

@jgarciao jgarciao

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgarciao @jstourac @bdattoma @asanzgom