Fix model serving tests in 2.6 #1125
Conversation
Robot Results
|
bdattoma
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ${url}= Get Element Attribute xpath://div[.="${model_name} "]${MS_TABLE_ENDPOINT_INPUT} value | ||
| SeleniumLibrary.Page Should Contain Element xpath://div[.="${model_name} "] | ||
| ${route_xpath}= Set Variable xpath://div[.="${model_name} "]${MS_TABLE_ENDPOINT_INPUT} | ||
| ${loaded}= Run Keyword And Return Status SeleniumLibrary.Wait Until Page Contains Element ${route_xpath} timeout=15s |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
bdattoma
changed the title
| ${loaded}= Run Keyword And Return Status SeleniumLibrary.Wait Until Page Contains Element ${route_xpath} timeout=15s | ||
| IF ${loaded} == ${FALSE} | ||
| SeleniumLibrary.Reload Page | ||
| SeleniumLibrary.Wait Until Page Contains Element ${route_xpath} timeout=15s | ||
| END |
There was a problem hiding this comment.
Isn't this masking a UI bug? Either the thing should appear without reloading, and then don't reload in the test, or it appears only after a reload, and then always reload. Not both.
There was a problem hiding this comment.
I never saw that particular page live, so I'm not sure which, but page reload should IMO never be necessary for a user to do, unless we are workarounding something just in a test.
There was a problem hiding this comment.
it's been reported to UI team already this morning, they will look into it. I'm going to add a warning for our tests when this IF branch is used
There was a problem hiding this comment.
I'm just afraid that this will get lost among all the warnings we already have in our tests 🙁
There was a problem hiding this comment.
it's a realistic scenario. The alternative was to leave test failing (not worth IMO for this small UI bug). But I'm open to alternative approaches
There was a problem hiding this comment.
Addition of the Jira to the code is good for me ATM 🙂 I don't have better proposal now.
There was a problem hiding this comment.
@bdattoma I would suggest to check if model is loaded in inference service then look for the xpath in the dashboard page
There was a problem hiding this comment.
I don't think it would solve, it seems a UI delay in refreshing the data
|
PR validation
|
bdattoma
added
verified
bdattoma
requested review from
jgarciao,
diegolovison,
nehachopra27,
jstourac,
FedeAlonso and
tarukumar
| SeleniumLibrary.Page Should Contain Element xpath://div[.="${model_name} "] | ||
| ${route_xpath}= Set Variable xpath://div[.="${model_name} "]${MS_TABLE_ENDPOINT_INPUT} | ||
| ${loaded}= Run Keyword And Return Status SeleniumLibrary.Wait Until Page Contains Element ${route_xpath} timeout=15s | ||
| IF ${loaded} == ${FALSE} |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
This is a kind of issue which imo is not worth to make the test failing bcos of it. I'm open to alternatives :) |
|
Some issues with model serving UI testing faced after the new changes in 2.6.
Likely, we just need to fix the teardown in
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm_UI.robotOther tentative fixes for timing issues:
Wait until keyword succeedes(both UI and CLI test)