-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 2.6 xpath fixes #1114
Fix: 2.6 xpath fixes #1114
Conversation
@@ -107,7 +107,7 @@ | |||
[Documentation] Checks if the owner of a DS project is displayed and corresponds to the expected one | |||
[Arguments] ${project_title} ${expected_username} | |||
Run Keyword And Continue On Failure | |||
... Page Should Contain Element xpath=//td[div/div/a[text()="${project_title}"]]/small[text()="${expected_username}"] | |||
... Page Should Contain Element xpath=//a[text()="${project_title}"]/ancestor::td[@data-label='Name']//small[text()="${expected_username}"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
@@ -309,7 +309,7 @@ | |||
${is_stopped}= Run Keyword And Return Status Workbench Status Should Be | |||
... workbench_title=${workbench_title} status=${WORKBENCH_STATUS_STOPPED} | |||
IF ${is_stopped} == ${TRUE} | |||
Click Element ${WORKBENCH_SECTION_XP}//tr[td[@data-label="Name"]/*[div[text()="${workbench_title}"]]]/td[@data-label="Status"]//span[@class="pf-c-switch__toggle"] | |||
Click Element ${WORKBENCH_SECTION_XP}//div[text()="${workbench_title}"]/ancestor::tr/td[@data-label="Status"]//label[@data-ouia-component-type="PF5/Switch"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
@@ -355,7 +355,7 @@ | |||
${is_starting}= Run Keyword And Return Status Workbench Status Should Be | |||
... workbench_title=${workbench_title} status=${WORKBENCH_STATUS_STARTING} | |||
IF ${is_started} == ${TRUE} or ${is_starting} == ${TRUE} | |||
Click Element ${WORKBENCH_SECTION_XP}//tr[td[@data-label="Name"]/*[div[text()="${workbench_title}"]]]/td[@data-label="Status"]//span[@class="pf-c-switch__toggle"] | |||
Click Element ${WORKBENCH_SECTION_XP}//div[text()="${workbench_title}"]/ancestor::tr/td[@data-label="Status"]//label[@data-ouia-component-type="PF5/Switch"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource
Fixed
Show fixed
Hide fixed
@@ -260,7 +261,7 @@ | |||
${is_started}= Run Keyword And Return Status Workbench Status Should Be From Projects Home Page | |||
... workbench_title=${workbench_title} status=${WORKBENCH_STATUS_RUNNING} project_title=${project_title} | |||
IF ${is_started} == ${TRUE} | |||
Click Element xpath=//tr[td/div/div/a[text()="${project_title}"]]/td//a[text()="${workbench_title}"] | |||
Click Element xpath=//tr//a[text()="${project_title}"]/ancestor::tr/td[@data-label="Workbench"]//a[text()="${workbench_title}"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
@@ -272,7 +273,7 @@ | |||
[Documentation] Checks the workbench launch link is disabled from DS Projects home page. | |||
[Arguments] ${workbench_title} ${project_title} | |||
${link_status}= Get Element Attribute | |||
... xpath=//tr[td/div/div/a[text()="${project_title}"]]/td//a[text()="${workbench_title}"] aria-disabled | |||
... xpath=//tr//a[text()="${project_title}"]/ancestor::tr/td[@data-label="Workbench"]//a[text()="${workbench_title}"] aria-disabled |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Wait Until Page Contains Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]/td[@class="pf-c-table__action"]/div/ul/li/button[text()="${action} ${item_type}"] | ||
Click Element xpath=//tr[td[@data-label="Name"]//*[text()="${item_title}"]]/td[@class="pf-c-table__action"]/div/ul/li/button[text()="${action} ${item_type}"] | ||
Click Element xpath=//*[text()="ODS-CI Common Prj"]/ancestor::tr//td/button[@aria-label="Kebab toggle"] | ||
Wait Until Page Contains Element xpath=//*[text()="${item_title}"]/ancestor::tr//td//li//span[text()="${action} ${item_type}"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as Jiri mentioned - don't forget to squash the commits with the merge 🙂
Not merging since it has a |
I did both (draft + don't merge) and forget to delete the label. |
Fix for tests:
ODS-1775 : Verify User Can Create A Data Science Project
ODS-1814: Verify User Can Create And Start A Workbench With Existent PV Storage
ODS-1818: Verify Users Can Start, Stop, Launch And Delete A Workbench
ODS-1813: Verify Users Can Start, Stop And Launch A Workbench From DS Projects Home Page