-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ODS-493 (and other Explore tab tests) for ODH 2.6 #1111
Fix ODS-493 (and other Explore tab tests) for ODH 2.6 #1111
Conversation
Signed-off-by: Jiri Daněk <[email protected]>
|
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Dismissed
Show dismissed
Hide dismissed
Robot Results
|
CI: rhods-ci-pr-test/2305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just wonder whether this is really deliberate change and not a bug... doesn't seem much user experience friendly to me :/
@jiridanek Have you tried to ask around?
@bdattoma asked this in #team-openshift-ai-dashboard What's the usual practice about issues like this? Merge a fix to have greener CI, or wait till complaints are addressed. I'd merge the test fix since I expect UI change might take long to get to us. Maybe first if wait to see what reception on the dashboard chat is. |
Yes, agree to merge this now. But it would be nice to create a tracking issue for this based on the discussion and eventually provide there link to this PR for our future reference so we can save a bit time during the next fix of the tests. |
In 2.5, the entire card is a click target
In 2.6, only the little circle (marked yellow in screenshot) is a click target