Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ODS-493 (and other Explore tab tests) for ODH 2.6 #1111

Merged

Conversation

jiridanek
Copy link
Member

In 2.5, the entire card is a click target

image

In 2.6, only the little circle (marked yellow in screenshot) is a click target

image

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiridanek jiridanek self-assigned this Jan 11, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
397 0 0 397 100

@jiridanek
Copy link
Member Author

CI: rhods-ci-pr-test/2305

@jiridanek jiridanek added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Jan 11, 2024
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just wonder whether this is really deliberate change and not a bug... doesn't seem much user experience friendly to me :/

@jiridanek Have you tried to ask around?

@jiridanek
Copy link
Member Author

@jiridanek Have you tried to ask around

@bdattoma asked this in #team-openshift-ai-dashboard

What's the usual practice about issues like this? Merge a fix to have greener CI, or wait till complaints are addressed.

I'd merge the test fix since I expect UI change might take long to get to us. Maybe first if wait to see what reception on the dashboard chat is.

@jstourac
Copy link
Member

Yes, agree to merge this now.

But it would be nice to create a tracking issue for this based on the discussion and eventually provide there link to this PR for our future reference so we can save a bit time during the next fix of the tests.

@jiridanek jiridanek merged commit 4a6071c into red-hat-data-services:master Jan 12, 2024
11 checks passed
@jiridanek jiridanek deleted the jd_ODS-493_little_circle branch January 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants