Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Automation ODS-2173 Verify user can create a workbench using Intel AiKit image #1107

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Test Automation ODS-2173 Verify user can create a workbench using Intel AiKit image #1107

merged 5 commits into from
Jan 16, 2024

Conversation

asanzgom
Copy link
Contributor

@asanzgom asanzgom commented Jan 11, 2024 •
edited by jstourac
Loading

Resolves: RHOAIENG-1176

CI: rhods-ci-pr-test/2322/ :white_check_mark:

@asanzgom asanzgom self-assigned this Jan 11, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2024
View reviewed changes
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Fixed Show fixed Hide fixed
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
398 0 0 398 100

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2024
View reviewed changes
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot
Verify user can create a workbench using Intel AiKit image
[Documentation] Verifies that a workbench can be created using Intel AiKit image
[Tags] ODS-2173 Tier2
Check And Install Operator in Openshift ${INTEL_AIKIT_OPERATOR_NAME} ${INTEL_AIKIT_APPNAME}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Check And Install Operator in Openshift' does not follow case convention
jgarciao
jgarciao reviewed Jan 11, 2024
View reviewed changes
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot Outdated
Comment on lines 50 to 51
${to_delete}= Create List ${PRJ_TITLE}
Set Suite Variable ${PROJECTS_TO_DELETE} ${to_delete}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option, I think easier to understand, could be to declare ${PROJECTS_TO_DELETE} as empty list in the suite's Variables section, and then use Append To List after the project is created

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource Show resolved Hide resolved
@asanzgom asanzgom requested review from bdattoma and jgarciao January 11, 2024 15:22
@jstourac
Copy link
Member

In general LGTM, thank you.

  • Could you please provide the jira link (or at least jira id) also directly into the commit message?
  • Could you please provide a CI run?

@asanzgom
Copy link
Contributor Author

In general LGTM, thank you.

* Could you please provide the jira link (or at least jira id) also directly into the commit message?

* Could you please provide a CI run?

@jstourac JIRA link is on the PR Description
what do you mean with CI run?

@jstourac
Copy link
Member

  • Yeah, it's in the PR description, would it be possible to have it in the commit message too?
  • CI run - I mean to provide info where we can see this in the action, e.g. rhods-ci-pr-test/xxxx

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2024
View reviewed changes
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot


*** Test Cases ***
Verify User Can Create A Workbench Using Intel AiKit Image

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test

Test case 'Verify User Can Create A Workbench Using Intel AiKit Image' is too long (22/20)
..._ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_notebook_images.robot


*** Test Cases ***
Verify User Can Create A Workbench Using Intel AiKit Image

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Verify User Can Create A Workbench Using Intel AiKit Image' has too many keywords inside (13/10)
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Jan 11, 2024
@jstourac jstourac self-requested a review January 11, 2024 17:00
@asanzgom asanzgom merged commit 38250a0 into red-hat-data-services:master Jan 16, 2024
11 checks passed
@asanzgom asanzgom deleted the feature/ods-2173 branch January 16, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jstourac jstourac jstourac approved these changes

@jgarciao jgarciao jgarciao approved these changes

Assignees

@asanzgom asanzgom

Labels
needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asanzgom @jstourac @jgarciao @bdattoma