Add ruff Python linter and suppress reported issues #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
added
the
utils
…kages in PyCharm Signed-off-by: Jakub Stejskal <[email protected]> Signed-off-by: Jiri Daněk <[email protected]>
* [Ruff: a fast Python linter](https://lwn.net/Articles/930487/) * [Ruff: The First 200 Releases](https://notes.crmarsh.com/ruff-the-first-200-releases) Even though ruff is not as good a linter as Pylint, it is still quite good and is _much_ faster: ``` $ time pylint ods_ci real 0m10.980s, user 0m10.745s, sys 0m0.179s $ time ruff ods_ci real 0m0.023s, user 0m0.040s, sys 0m0.017s ``` Signed-off-by: Jiri Daněk <[email protected]>
Robot Results
|
|
|
This PR originally comes from an older draft. I am splitting it into three PRs. This PR is second in the series. It adds the linter as a dev dependency, configuration for it, and github action for it. I will send a PR that fixes the found issues after this PR is merged. It follows up on this other PR (which should be merged first) |
jiridanek
commented
Jan 5, 2024
Comment on lines
+128
to
+150
| # TODO(jdanek) | ||
| "C416", # Unnecessary `list` comprehension (rewrite using `list()`) | ||
| "E117", # Over-indented | ||
| "E231", # Missing whitespace after ',' | ||
| "E401", # Multiple imports on one line | ||
| "E402", # Module level import not at top of file | ||
| "E711", # Comparison to `None` should be `cond is not None` | ||
| "E712", # Comparison to `True` should be `cond is True` or `if cond:` | ||
| "E721", # Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks | ||
| "E722", # Do not use bare `except` | ||
| "F401", # `re` imported but unused | ||
| "F403", # `from python_terraform import *` used; unable to detect undefined names | ||
| "F405", # `IsNotFlagged` may be undefined, or defined from star imports | ||
| "F541", # f-string without any placeholders | ||
| "F811", # Redefinition of unused `hide_values_in_op_json` from line 565 | ||
| "F821", # Undefined name `os` | ||
| "PIE790", # Unnecessary `pass` statement | ||
| "PLR1714", # Consider merging multiple comparisons. Use a `set` if the elements are hashable. | ||
| "Q004", # Unnecessary escape on inner quote character | ||
| "RET507", # Unnecessary `else` after `continue` statement | ||
| "RET508", # Unnecessary `elif` after `break` statement | ||
| "W292", # No newline at end of file | ||
| "W293", # Blank line contains whitespace |
There was a problem hiding this comment.
I'll send a subsequent PR(s) to fix all this.
Frawless
approved these changes
Jan 5, 2024
jstourac
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though ruff is not as good a linter as Pylint, it is still quite good and is much faster: