Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-1179 Verify user can create a workbench with an existing data connection #1094

Merged
merged 4 commits into from
Jan 8, 2024
Merged

RHOAIENG-1179 Verify user can create a workbench with an existing data connection #1094

merged 4 commits into from
Jan 8, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 3, 2024 •
edited
Loading

CI: rhods-ci-pr-test/2271
Task to create the test: https://issues.redhat.com/browse/RHOAIENG-1179
Bug ticket that's tested: https://issues.redhat.com/browse/RHODS-5700

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 3, 2024
View reviewed changes
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Fixed Show fixed Hide fixed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
392 0 0 392 100

@jiridanek jiridanek marked this pull request as draft January 3, 2024 12:23
@jiridanek jiridanek marked this pull request as ready for review January 3, 2024 19:35
@jiridanek jiridanek force-pushed the jd_2024_01/_03_data_connection_pr branch from df895eb to 5319b14 Compare January 3, 2024 19:36
@jstourac jstourac added verified This PR has been tested with Jenkins new test New test(s) added (PR will be listed in release-notes) labels Jan 4, 2024
jstourac
jstourac previously requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@jstourac jstourac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jiri. I put two comments. Otherwise LGTM.

Could you please add the link to the issue into the PR description to be handy? Thanks!

Edit: also, it would be nice to have just one commit with a decent commit message too though 😉

ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource Outdated Show resolved Hide resolved
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot Outdated Show resolved Hide resolved
@jiridanek
Copy link
Member Author

Edit: also, it would be nice to have just one commit with a decent commit message too though 😉

I'm used to doing a squash in GitHub UI when I copy over the issue title into the squashed commit's commit message. Maybe that won't work here, given how the merge checks work and whether squash merge is even enabled in this repo.

I'll squash the commits on my own and forcepush instead.

@jiridanek jiridanek changed the title ODS-2176 Verify user can create a workbench with an existing data connection RHOAIENG-1179 Verify user can create a workbench with an existing data connection Jan 4, 2024
@jiridanek jiridanek force-pushed the jd_2024_01/_03_data_connection_pr branch from 5319b14 to c5ff606 Compare January 4, 2024 09:31
@jiridanek jiridanek force-pushed the jd_2024_01/_03_data_connection_pr branch from c5ff606 to 5e33733 Compare January 4, 2024 09:34
@jiridanek
Copy link
Member Author

CI rerun: rhods-ci-pr-test/2282

@jiridanek jiridanek requested a review from jstourac January 4, 2024 10:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jiridanek jiridanek dismissed jstourac’s stale review January 4, 2024 12:00

changes been made, ci passing

@jiridanek
Copy link
Member Author

@jstourac new CI run, rhods-ci-pr-test/2287

@diegolovison diegolovison merged commit 8297c4a into red-hat-data-services:master Jan 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jstourac jstourac jstourac approved these changes

@lugi0 lugi0 Awaiting requested review from lugi0

Assignees

@jiridanek jiridanek

Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiridanek @jstourac @bdattoma @diegolovison