Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for old Hive with Openstack #1089

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

manosnoam
Copy link
Contributor

For Openstack in older Hive version, we need to ignore ClusterClaim that does not show ClusterRunning condition as true, while the cluster is actually running, but displaying Resuming. For example:
image

This is a workaround to assume Openstack cluster is running, if the ClusterClain condition shows a reason of Resuming:
image

Ignore Hive ClusterClaim when displayed as Resuming
since it is actually Running

Signed-off-by: manosnoam <[email protected]>
@manosnoam manosnoam added the verified This PR has been tested with Jenkins label Dec 24, 2023
@@ -152,6 +152,11 @@
${provision_status} = Run Process oc -n ${pool_namespace} wait --for\=condition\=Provisioned\=True cd ${pool_namespace} --timeout\=5m shell=yes
${web_access} = Run Process oc -n ${pool_namespace} get cd ${pool_namespace} -o json | jq -r '.status.webConsoleURL' --exit-status shell=yes
${claim_status} = Run Process oc -n ${hive_namespace} wait --for\=condition\=ClusterRunning\=True clusterclaim ${claim_name} --timeout\=5m shell=yes
# Workaround for old Hive with Openstack - Cluster is displayed as Resuming even when it is Running
IF "${provider_type}" == "OSP"

Check notice

Code scanning / Robocop

Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion Note

Variable '${provider_type}' in 'IF' condition has unnecessary string conversion
@@ -152,6 +152,11 @@
${provision_status} = Run Process oc -n ${pool_namespace} wait --for\=condition\=Provisioned\=True cd ${pool_namespace} --timeout\=5m shell=yes
${web_access} = Run Process oc -n ${pool_namespace} get cd ${pool_namespace} -o json | jq -r '.status.webConsoleURL' --exit-status shell=yes
${claim_status} = Run Process oc -n ${hive_namespace} wait --for\=condition\=ClusterRunning\=True clusterclaim ${claim_name} --timeout\=5m shell=yes
# Workaround for old Hive with Openstack - Cluster is displayed as Resuming even when it is Running
IF "${provider_type}" == "OSP"
${claim_status} = Run Process

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning

Trailing whitespace at the end of line
# Workaround for old Hive with Openstack - Cluster is displayed as Resuming even when it is Running
IF "${provider_type}" == "OSP"
${claim_status} = Run Process
... oc -n ${hive_namespace} get clusterclaim ${claim_name} -o json | jq '.status.conditions[] | select(.type\=\="ClusterRunning" and .reason\=\="Resuming")' --exit-status shell=yes

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning

Line is too long (191/120)
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
391 0 0 391 100

@manosnoam manosnoam requested a review from kobihk December 24, 2023 10:27
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jstourac
Copy link
Member

jstourac commented Jan 2, 2024

@manosnoam

Is the trailing whitespace robocop warning possible to be removed?

Since you mention the old Hive - is this issue present also in the new Hive instance we're about to migrate to?

@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Jan 2, 2024
@manosnoam manosnoam merged commit 3c5ad0d into red-hat-data-services:master Jan 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants