-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for old Hive with Openstack #1089
Conversation
Ignore Hive ClusterClaim when displayed as Resuming since it is actually Running Signed-off-by: manosnoam <[email protected]>
@@ -152,6 +152,11 @@ | |||
${provision_status} = Run Process oc -n ${pool_namespace} wait --for\=condition\=Provisioned\=True cd ${pool_namespace} --timeout\=5m shell=yes | |||
${web_access} = Run Process oc -n ${pool_namespace} get cd ${pool_namespace} -o json | jq -r '.status.webConsoleURL' --exit-status shell=yes | |||
${claim_status} = Run Process oc -n ${hive_namespace} wait --for\=condition\=ClusterRunning\=True clusterclaim ${claim_name} --timeout\=5m shell=yes | |||
# Workaround for old Hive with Openstack - Cluster is displayed as Resuming even when it is Running | |||
IF "${provider_type}" == "OSP" |
Check notice
Code scanning / Robocop
Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion Note
@@ -152,6 +152,11 @@ | |||
${provision_status} = Run Process oc -n ${pool_namespace} wait --for\=condition\=Provisioned\=True cd ${pool_namespace} --timeout\=5m shell=yes | |||
${web_access} = Run Process oc -n ${pool_namespace} get cd ${pool_namespace} -o json | jq -r '.status.webConsoleURL' --exit-status shell=yes | |||
${claim_status} = Run Process oc -n ${hive_namespace} wait --for\=condition\=ClusterRunning\=True clusterclaim ${claim_name} --timeout\=5m shell=yes | |||
# Workaround for old Hive with Openstack - Cluster is displayed as Resuming even when it is Running | |||
IF "${provider_type}" == "OSP" | |||
${claim_status} = Run Process |
Check warning
Code scanning / Robocop
Trailing whitespace at the end of line Warning
# Workaround for old Hive with Openstack - Cluster is displayed as Resuming even when it is Running | ||
IF "${provider_type}" == "OSP" | ||
${claim_status} = Run Process | ||
... oc -n ${hive_namespace} get clusterclaim ${claim_name} -o json | jq '.status.conditions[] | select(.type\=\="ClusterRunning" and .reason\=\="Resuming")' --exit-status shell=yes |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
Robot Results
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Is the Since you mention the |
For Openstack in older Hive version, we need to ignore ClusterClaim that does not show
ClusterRunning
condition as true, while the cluster is actually running, but displayingResuming
. For example:This is a workaround to assume Openstack cluster is running, if the ClusterClain condition shows a reason of
Resuming
: