Keywords for management of components #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
2 times, most recently
from
ff89545 to
35399da
Compare
Robot Results
|
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
35399da to
301e02a
Compare
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
301e02a to
c014bd2
Compare
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
2 times, most recently
from
24c4341 to
8d26748
Compare
sutaakar
previously approved these changes
Jan 4, 2024
|
LGTM, one proposal for an improvement would be to unify the code - so these two keywords would use one common implementation by addition also the |
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
8d26748 to
bf0f108
Compare
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
bf0f108 to
dfb6efa
Compare
jstourac
reviewed
Jan 4, 2024
jstourac
requested changes
Jan 4, 2024
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
dfb6efa to
a7e1312
Compare
| [Arguments] ${component} ${state} | ||
| ${result} = Run Process oc get datascienceclusters.datasciencecluster.opendatahub.io -o name | ||
| ... shell=true stderr=STDOUT | ||
| IF $result.stdout == "" |
Check notice
Code scanning / Robocop
IF can be replaced with inline IF Note
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
a7e1312 to
4f81598
Compare
jiripetrlik
force-pushed
the
fix-ds-cluster-name
branch
from
4f81598 to
854b68c
Compare
|
| FAIL Can not find datasciencecluster | ||
| END | ||
| ${cluster_name} = Set Variable ${result.stdout} | ||
| ${result} = Run Process oc patch ${cluster_name} --type 'json' -p '[{"op" : "replace" ,"path" : "/spec/components/${component}/managementState" ,"value" : "${state}"}]' |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
jstourac
approved these changes
Jan 4, 2024
jstourac
added
the
enhancements
sutaakar
approved these changes
Jan 5, 2024
jgarciao
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.