Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After installation, verify the monitoring stack only for managed #1077

Merged
merged 3 commits into from
Dec 15, 2023
Merged

After installation, verify the monitoring stack only for managed #1077

merged 3 commits into from
Dec 15, 2023

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented Dec 13, 2023 •
edited
Loading

  • Starting at RHOAI 2.5 the modelmesh monitoring stack is no longer deployed in redhat-ods-monitoring.
  • Disabling this check for Self-Managed will save 20 mins in RHOAI Self-Managed installation
  • Note: clusters upgrading 2.4 > 2.5 still will have the modelserving monitoring stack until https://issues.redhat.com/browse/RHOAIENG-293 is solved

@jgarciao jgarciao requested review from lugi0 and tarukumar December 13, 2023 09:13
@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Dec 13, 2023
@jgarciao jgarciao requested a review from bdattoma December 13, 2023 09:13
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
389 0 0 389 100

bdattoma
bdattoma previously approved these changes Dec 13, 2023
View reviewed changes
@jgarciao jgarciao changed the title Remove verification of deprecated model serving monitoring after installation Verify the monitoring stack only for managedRemove verification of deprecated model serving monitoring after installation Dec 13, 2023
@jgarciao jgarciao changed the title Verify the monitoring stack only for managedRemove verification of deprecated model serving monitoring after installation After installation, verify the monitoring stack only for managed Dec 13, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 13, 2023
View reviewed changes
ods_ci/tasks/Resources/RHODS_OLM/install/oc_install.robot
Log Verified Monitoring NS: ${MONITORING_NAMESPACE} console=yes

# Monitoring stack only deployed for managed, as modelserving monitoring stack is no longer deployed
IF "${cluster_type}" == "managed"

Check notice

Code scanning / Robocop

Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion Note

Variable '${cluster_type}' in 'IF' condition has unnecessary string conversion
@jgarciao jgarciao added the needs testing Needs to be tested in Jenkins label Dec 13, 2023
@jgarciao jgarciao requested a review from bdattoma December 13, 2023 10:58
lugi0
lugi0 previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdattoma
Copy link
Contributor

apart from Tarun's comments, lgtm

jstourac
jstourac reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once you provide a test run, I'm all for it 🙂

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao
Copy link
Contributor Author

Tested successfully here: rhods-smoke/4210

@jgarciao jgarciao added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Dec 15, 2023
@jgarciao jgarciao merged commit fecbc0a into red-hat-data-services:master Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarukumar tarukumar tarukumar left review comments

@jstourac jstourac jstourac left review comments

@bdattoma bdattoma bdattoma approved these changes

@lugi0 lugi0 lugi0 approved these changes

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgarciao @bdattoma @jstourac @lugi0 @tarukumar