Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kserve UI tests #1062

Merged
merged 15 commits into from
Dec 8, 2023
Merged

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Dec 6, 2023

Testing in rhods-ci-pr-test/2178

Adds a set of basic tests for Kserve deployed models using the RHOAI UI

Signed-off-by: Luca Giorgi <[email protected]>
@lugi0 lugi0 added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Dec 6, 2023
@lugi0 lugi0 self-assigned this Dec 6, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
388 0 0 388 100

@tarukumar
Copy link
Contributor

Generally, it appears good. However, we might consider updating the keyword and refining the inference related to the workbench name, even when we select all projects in the dropdown. This could be enhance we can do in the future

@lugi0
Copy link
Contributor Author

lugi0 commented Dec 7, 2023

@tarukumar yes in general there's many improvements that could (should) be made, e.g. reducing duplication between this suite and the CLI suite by centralizing shared or partly shared keyword etc. I'd still like to get this merged as is so that we can start having consistent automated testing of the UI and update this further down the line

@jstourac
Copy link
Member

jstourac commented Dec 7, 2023

@lugi0 the Polarion IDs, is it planned to be updated later too?

@lugi0
Copy link
Contributor Author

lugi0 commented Dec 7, 2023

@jstourac no I will update with the correct Polarion IDs ASAP before merging

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have very little knowledge about the topic, but in general this LGTM (even though, there are a handful of robot warnings that could be easily fixed) 🙃 🙂

@lugi0
Copy link
Contributor Author

lugi0 commented Dec 7, 2023

Validated once in rhods-ci-pr-test/2187, rerunning in rhods-ci-pr-test/2188 after last commit to ensure nothing broke

@lugi0
Copy link
Contributor Author

lugi0 commented Dec 7, 2023

Obviously everything broke :) Retesting for hopefully the last time: rhods-ci-pr-test/2189

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lugi0 lugi0 added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Dec 7, 2023
@lugi0
Copy link
Contributor Author

lugi0 commented Dec 7, 2023

verified in rhods-ci-pr-test/2191

Copy link
Member

@mwaykole mwaykole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar merged commit 15ebcb9 into red-hat-data-services:master Dec 8, 2023
8 checks passed
Comment on lines +294 to +295
Try Opening Create Server
Wait for RHODS Dashboard to Load wait_for_cards=${FALSE} expected_page=Data Science Projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to handle this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try Opening Create Server deletes all existing projects to test with only a single DS Project present - This way we can force multiple projects at the same time by specifying singel_prj=${FALSE}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants