-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kserve UI tests #1062
Add Kserve UI tests #1062
Conversation
Signed-off-by: Luca Giorgi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Generally, it appears good. However, we might consider updating the keyword and refining the inference related to the workbench name, even when we select all projects in the dropdown. This could be enhance we can do in the future |
…ctly Signed-off-by: Luca Giorgi <[email protected]>
@tarukumar yes in general there's many improvements that could (should) be made, e.g. reducing duplication between this suite and the CLI suite by centralizing shared or partly shared keyword etc. I'd still like to get this merged as is so that we can start having consistent automated testing of the UI and update this further down the line |
@lugi0 the Polarion IDs, is it planned to be updated later too? |
@jstourac no I will update with the correct Polarion IDs ASAP before merging |
Signed-off-by: Luca Giorgi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have very little knowledge about the topic, but in general this LGTM (even though, there are a handful of robot warnings that could be easily fixed) 🙃 🙂
Signed-off-by: Luca Giorgi <[email protected]>
Validated once in rhods-ci-pr-test/2187, rerunning in rhods-ci-pr-test/2188 after last commit to ensure nothing broke |
Signed-off-by: Luca Giorgi <[email protected]>
Obviously everything broke :) Retesting for hopefully the last time: rhods-ci-pr-test/2189 |
Signed-off-by: Luca Giorgi <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
verified in rhods-ci-pr-test/2191 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Try Opening Create Server | ||
Wait for RHODS Dashboard to Load wait_for_cards=${FALSE} expected_page=Data Science Projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to handle this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try Opening Create Server
deletes all existing projects to test with only a single DS Project present - This way we can force multiple projects at the same time by specifying singel_prj=${FALSE}
Testing in rhods-ci-pr-test/2178
Adds a set of basic tests for Kserve deployed models using the RHOAI UI