Enable Ray and Codeflare for DW tests #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
sutaakar
previously approved these changes
Dec 5, 2023
jgarciao
previously approved these changes
Dec 5, 2023
| FAIL Unable to clone Codeflare repo ${CODEFLARE_REPO_URL}:${CODEFLARE_REPO_BRANCH} | ||
| END | ||
|
|
||
| ${result} = Run Process oc patch datascienceclusters.datasciencecluster.opendatahub.io default-dsc --type 'json' -p '[{"op" : "replace" ,"path" : "/spec/components/ray/managementState" ,"value" : "Managed"}]' |
There was a problem hiding this comment.
Could you create a new keyword (in this or a follow-up PR) for this in ods_ci/tasks/Resources/RHODS_OLM/install/oc_install.robot?
@lugi0 Do you agree with this approach?
Enable Component
[Documentation] Enables a component in Data Science Cluster
[Arguments] ${component} ${dsc_name}=${DSC_NAME}
...
Disable Component
[Documentation] Disables a component in Data Science Cluster
[Arguments] ${component} ${dsc_name}=${DSC_NAME}
...
There was a problem hiding this comment.
Yes, will address this in the follow up PR.
jgarciao
added
the
enhancements
jiripetrlik
force-pushed
the
enable-ray-codeflare
branch
from
34f8205 to
2dc1293
Compare
jiripetrlik
force-pushed
the
enable-ray-codeflare
branch
from
2dc1293 to
9bb34e5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jgarciao
approved these changes
Dec 5, 2023
sutaakar
approved these changes
Dec 5, 2023
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.