Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip pre-req install by default in the KServe test suite #1053

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Skip pre-req install by default in the KServe test suite #1053

merged 1 commit into from
Nov 29, 2023

Conversation

bdattoma
Copy link
Contributor

To avoid conflicts after #1039 got merged, we should skip installing the pre-requirements in the KServe suite.
The suite can still install them by setting SKIP_PREREQS_INSTALL variable to False at runtime

@bdattoma bdattoma requested a review from jgarciao November 29, 2023 09:11
@bdattoma bdattoma self-assigned this Nov 29, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bdattoma bdattoma mentioned this pull request Nov 29, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
372 0 0 372 100

@jstourac
Copy link
Member

Isn't it possible to check whether these prerequisities are installed already? 🤔

@bdattoma
Copy link
Contributor Author

Isn't it possible to check whether these prerequisities are installed already? 🤔

yes it's possible. We could implement a check in future PRs, it would take time we don't have now and the benefit would be minimal

@jstourac
Copy link
Member

yes it's possible. We could implement a check in future PRs, it would take time we don't have now and the benefit would be minimal

Maybe I'm missing something but I don't agree that the benefit would be minimal 🙂 Anyway, I agree that we need this fast.

@bdattoma
Copy link
Contributor Author

yes it's possible. We could implement a check in future PRs, it would take time we don't have now and the benefit would be minimal

Maybe I'm missing something but I don't agree that the benefit would be minimal 🙂 Anyway, I agree that we need this fast.

we can talk offline

@bdattoma bdattoma merged commit 3a2fe14 into red-hat-data-services:master Nov 29, 2023
8 checks passed
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
@bdattoma
skip pre-req install by default (red-hat-data-services#1053)
3872e65 
Signed-off-by: bdattoma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lugi0 lugi0 lugi0 approved these changes

@jstourac jstourac jstourac approved these changes

@aloganat aloganat aloganat approved these changes

@jgarciao jgarciao Awaiting requested review from jgarciao

@tarukumar tarukumar Awaiting requested review from tarukumar

@asanzgom asanzgom Awaiting requested review from asanzgom

Assignees

@bdattoma bdattoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdattoma @jstourac @aloganat @lugi0