Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dsc default name #1045

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Update dsc default name #1045

merged 3 commits into from
Nov 28, 2023

Conversation

bdattoma
Copy link
Contributor

Default name for DSC object is changed in the product and our tests are not able to find the correct one.

@bdattoma
update dsc name
5e83bd5 
Signed-off-by: bdattoma <[email protected]>
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Nov 28, 2023
@bdattoma bdattoma requested review from jgarciao and lugi0 November 28, 2023 11:06
@bdattoma bdattoma self-assigned this Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
372 0 0 372 100

@bdattoma
use variable
4fee7cf 
Signed-off-by: bdattoma <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2023
View reviewed changes
ods_ci/tasks/Resources/RHODS_OLM/install/oc_install.robot
@@ -186,7 +186,7 @@

Apply DataScienceCluster CustomResource
[Documentation]
[Arguments] ${dsc_name}=default
[Arguments] ${dsc_name}=${DSC_NAME}

Check warning

Code scanning / Robocop

Keyword argument '{{ name }}' is not used Warning

Keyword argument '${dsc_name}' is not used
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Nov 28, 2023
@jstourac
Copy link
Member

jstourac commented Nov 28, 2023 •
edited
Loading

What about these?

@jgarciao jgarciao merged commit 96f9b10 into red-hat-data-services:master Nov 28, 2023
8 checks passed
@bdattoma
Copy link
Contributor Author

What about these?

discussed in a meeting

ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
@bdattoma
Update dsc default name (red-hat-data-services#1045)
d777cc9 
* update dsc name

Signed-off-by: bdattoma <[email protected]>

* use variable

Signed-off-by: bdattoma <[email protected]>

* move skip before rhosi setup in llm

Signed-off-by: bdattoma <[email protected]>

---------

Signed-off-by: bdattoma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeAlonso FedeAlonso FedeAlonso approved these changes

@jgarciao jgarciao jgarciao approved these changes

@lugi0 lugi0 Awaiting requested review from lugi0

Assignees

@bdattoma bdattoma

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdattoma @jstourac @jgarciao @FedeAlonso