[Fix] test to check various user group access

[jstourac]

The existing test checks that users from different groups have different
access and that this access can be setup via RHOAI User settings.

What this test does:

• creates a custom-admins-group with TEST_USER2 user
• creates a custom-users-group with TEST_USER3 user
• configures first group as admins in RHOAI User settings
• configures second group as users in RHOAI User settings

Once this was applied it tried to perform operations with three
different users:

• TEST_USER - expected no privileges and simple Access permissions needed page presented
• TEST_USER2 - all privileges
• TEST_USER3 - no Administration page shown

Problem in this approach is that the TEST_USER is part of the
dedicated-admins group, which has a cluster-admin role in our
default cluster settings. Per this [1], such user is an admin by
default.

So my changes incorporates usage of the TEST_USER4 instead of
TEST_USER.

Also, unnecessary check for the product version is removed with this
commit.

[1] https://access.redhat.com/documentation/en-us/red_hat_openshift_data_science/1/html-single/managing_users_and_user_resources/index#defining-openshift-data-science-admin-and-user-groups_user-mgmt

By default, users with cluster admin permissions and users in the
dedicated-admins administrator group are OpenShift Data Science
administrators, but all users authenticated in OpenShift can access
OpenShift Data Science. A cluster admin is a superuser that can perform
any action in any project in the OpenShift cluster.

---

CI: rhods-ci-pr-test/2159

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
372	0	0	372	100

[bdattoma]

@jstourac

htpasswd-cluster-admin - expected no privileges and simple Access permissions needed page presented

I think this is not correct, because the test uses TEST_USER who is not htpasswd-cluster-admin

[jstourac]

@jstourac

htpasswd-cluster-admin - expected no privileges and simple Access permissions needed page presented

I think this is not correct, because the test uses TEST_USER who is not htpasswd-cluster-admin

Uf, you're right, Berto; good catch:

TEST_USER:
  AUTH_TYPE: ldap-provider-qe
  USERNAME: ldap-admin1

I have it modified in my local properties settings, damn.

Anyway, I've checked the cluster config for the ldap-admin1 and the situation is same - it is part of the dedicated-admins group, which has a role of cluster-admin assigned. I'll update the description.

Not sure for how long this test been failing in which release this got changed.

[bdattoma]

@jstourac

htpasswd-cluster-admin - expected no privileges and simple Access permissions needed page presented

I think this is not correct, because the test uses TEST_USER who is not htpasswd-cluster-admin

Uf, you're right, Berto; good catch:

TEST_USER:
  AUTH_TYPE: ldap-provider-qe
  USERNAME: ldap-admin1

I have it modified in my local properties settings, damn.

Anyway, I've checked the cluster config for the ldap-admin1 and the situation is same - it is part of the dedicated-admins group, which has a role of cluster-admin assigned. I'll update the description.

Not sure for how long this test been failing in which release this got changed.

yeah, this is actually an environement issue rather than test issue, because the script our CI uses to create IDPs assignes wrong permissions to some users. We should fix it there, I haven't done it yet because I was working on a new script for IDPs (which is completed and used by interop team).

In the meantime I'm okay with fixing the test. You can have a look at how it's been done in ods_ci/tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_permissions_mgmt.robot where there is a test setup which ensure the users have the right permissions: Set User Groups For Testing kw.

requested changes have been incorporated already, dismissing to be able to merge this one

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information