[Fix] custom image tests and one test removal #1030
Conversation
jstourac
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
jstourac
added
verified
|
@jstourac can you please add screenshot of test execution, and test job number ? |
|
@jstourac has |
It's part of the description already. Shall we really include also the screenshot here?
Well, based on the descriptions of these two: and Now the functionality doesn't allow you to create custom image in both of these cases. So the latter one doesn't make sense to me anymore. |
Looking at the build I see it did not pass: Can you run again and share results ? |
|
@manosnoam as mentioned in the PR description, re-execution won't help in these two cases. Or are you referring to something else? |
| @@ -55,26 +57,25 @@ Verify Custom Image Can Be Added | |||
| #Should Match ${spawner_packages} ${IMG_PACKAGES} | |||
|
|
|||
| Spawn Notebook With Arguments image=${IMAGESTREAM_NAME} size=Small | |||
| [Teardown] Custom Image Teardown | |||
| ${CLEANUP}= Set Variable True | |||
There was a problem hiding this comment.
The reason of using this variable is because you need all the steps in the keyword to be executed before cleaning up?
If that's the reason, you can use the tags robot:continue-on-failure or robot:recursive-continue-on-failure to force all steps being executed. There is more info here: https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#continue-on-failure
There was a problem hiding this comment.
The reason I added it here is to distinguish the behavior of the Custom Image Teardown. By default it performs also cleanup operations that are tied with the Jupyter Notebook environment. But this part isn't necessary if the test execution fails before this line. So the default value is set to false. Maybe your approach could be used for this too, but I went the way without modifying the current teardown keyword.
I think we should see that all the smoke tests passed, to indicate that the patch did not break anything.
|
|
@manosnoam well, how can I make these tests passed since these are product bugs there? |
The custom image tests need to be updated since the UI has changed.
Since the behaviour of the custom image creation now is that you cannot create an image with a wrong image location at all, this test simply duplicates what is covered in `Test Bad Image URL` already.
jstourac
force-pushed
the
fixCustomImage
branch
from
a1c3bbd to
4a8fe36
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
…1030) * [Fix] Update of custom image tests to match current UI The custom image tests need to be updated since the UI has changed. * Delete of the `Test Bad Image Import` from custom images suite Since the behaviour of the custom image creation now is that you cannot create an image with a wrong image location at all, this test simply duplicates what is covered in `Test Bad Image URL` already.
This fixes custom image tests against 2.4 RC2 release and removes one test that I believe is redundant now.
There are two tests failing due to the product bug, issues tracked here:
CI: rhods-ci-pr-test/2148