Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix managed #1022

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix managed #1022

merged 2 commits into from
Nov 21, 2023

Conversation

tarukumar
Copy link
Contributor

No description provided.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -66,7 +66,7 @@
${is_codeflare_managed} = Is CodeFlare Managed
Log Will verify CodeFlare operator: ${is_codeflare_managed} console=yes
IF ${is_codeflare_managed} CodeFlare Operator Should Be Installed
IF "${UPDATE_CHANNEL}" != "beta"
IF "${cluster_type}" != "managed"

Check notice

Code scanning / Robocop

Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion

Variable '${cluster_type}' in 'IF' condition has unnecessary string conversion
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
373 0 0 373 100

@aloganat aloganat merged commit 941c7fd into red-hat-data-services:master Nov 21, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
* Add support to not create DCS for managed cluster

Signed-off-by: Tarun Kumar <[email protected]>

* Add support to not create DCS for managed cluster

Signed-off-by: Tarun Kumar <[email protected]>

---------

Signed-off-by: Tarun Kumar <[email protected]>
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
* Add support to not create DCS for managed cluster

Signed-off-by: Tarun Kumar <[email protected]>

* Add support to not create DCS for managed cluster

Signed-off-by: Tarun Kumar <[email protected]>

---------

Signed-off-by: Tarun Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants