[Fix] Tests.Jupyterhub.test-pipChanges-not-permanent #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
added
verified
jgarciao
requested changes
Nov 9, 2023
ods_ci/tests/Tests/500__jupyterhub/test-pipChanges-not-permanent.robot
Outdated
Show resolved
Hide resolved
ods_ci/tests/Tests/500__jupyterhub/test-pipChanges-not-permanent.robot
Outdated
Show resolved
Hide resolved
jstourac
force-pushed
the
fixNtbPipPermanent
branch
from
6a9a207 to
95749db
Compare
- the `paramiko` is now part of the `science-notebook` so let's use the `minimal-notebook` instead - also, this notebook should be smaller so it could be spinned up a bit faster. - the default maximum timeout for the check of `import paramiko` failure is too long, let's wait up to 10seconds max. Relates to: opendatahub-io/notebooks#261
jstourac
force-pushed
the
fixNtbPipPermanent
branch
from
95749db to
c8254e3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bdattoma
approved these changes
Nov 9, 2023
what's the logic behind this choice? apart from minimal-nb to be smaller @jstourac |
@bdattoma Installation of |
jgarciao
approved these changes
Nov 9, 2023
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
…rvices#1015) - the `paramiko` is now part of the `science-notebook` so let's use the `minimal-notebook` instead - also, this notebook should be smaller so it could be spinned up a bit faster. - the default maximum timeout for the check of `import paramiko` failure is too long, let's wait up to 10seconds max. Relates to: opendatahub-io/notebooks#261
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
…rvices#1015) - the `paramiko` is now part of the `science-notebook` so let's use the `minimal-notebook` instead - also, this notebook should be smaller so it could be spinned up a bit faster. - the default maximum timeout for the check of `import paramiko` failure is too long, let's wait up to 10seconds max. Relates to: opendatahub-io/notebooks#261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paramikois now part of thescience-notebookso let's use theminimal-notebookinstead - also, this notebook should be smaller so it could be spinned up a bit faster.import paramikofailure is too long, let's wait up to 10seconds max.Relates to: opendatahub-io/notebooks#261
CI: rhods-ci-pr-test/2112